Skip to content

RFC "notify-device" for cross-driver readiness notification

Matthias Schiffer linux-bluetooth linux-devicetree linux-wireless lkml netdev oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest5 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5misc: introduce notify-device driverdrivers/misc/Kconfig drivers/misc/Makefile drivers/misc/notify-device.c +1 more+147 -05 replies
2/5wireless: mwifiex: signal firmware readiness using notify-devicedrivers/net/wireless/marvell/mwifiex/main.c drivers/net/wireless/marvell/mwifiex/main.h+15 -00 replies
3/5bluetooth: hci_mrvl: select firmwares to load by match datadrivers/bluetooth/hci_mrvl.c+46 -110 replies
4/5bluetooth: hci_mrvl: add support for SD8987drivers/bluetooth/hci_mrvl.c+3 -00 replies
5/5bluetooth: hci_mrvl: allow waiting for firmware load using notify-devicedrivers/bluetooth/hci_mrvl.c+17 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/5] "notify-device" for cross-driver readiness notification

This patch series is obviously missing documentation, MAINTAINERS entries, etc., but I'd like to solicit some basic feedback on whether this approach makes sense at all before I proceed. If it does, the naming is also very much open for bikeshedding - I'm not too happy with "notify-device".

The basic problem that the notify-device tries to solve is the synchronization of firmware loading readiness between the Marvell/NXP WLAN and Bluetooth drivers, but it may also be applicable to other drivers.

The WLAN and Bluetooth adapters are handled by separate drivers, and may be connected to the CPU using different interfaces (for example SDIO for WLAN and UART for Bluetooth). However, both adapters share a single firmware that may be uploaded via either interface.

For the SDIO+UART case, uploading the firmware via SDIO is usually preferable, but even when the interface doesn't matter, it seems like a good idea to clearly define which driver should handle it. To avoid making the Bluetooth driver more complicated than necessary in this case, we'd like to defer the probing of the driver until the firmware is ready.

For this purpose, we are introducing a notify-device, with the following properties:

- The device is created by a driver as soon as some "readiness condition" is satisfied
- Creating the device also binds a stub driver, so deferred probes are triggered
- Looking up the notify device is possible via OF node / phandle reference

This approach avoids a hard dependency between the WLAN and Bluetooth driver, and works regardless of the driver load order.

The first patch implementes the notify-device driver itself, and the rest shows how the device could be hooked up to the mwifiex and hci_mrvl drivers. A device tree making use of the notify-device could look like the following:

    &sdhci1 {
        wifi@1 {
            compatible = "marvell,sd8987";
            reg = <1>;
    
            wifi_firmware: firmware-notifier {};
        };
    };

    &main_uart3 {
        bluetooth {
            compatible = "marvell,sd8987-bt";
            firmware-ready = <&wifi_firmware>;
        };
    };

Matthias Schiffer (5):
misc: introduce notify-device driver
wireless: mwifiex: signal firmware readiness using notify-device
bluetooth: hci_mrvl: select firmwares to load by match data
bluetooth: hci_mrvl: add support for SD8987
bluetooth: hci_mrvl: allow waiting for firmware load using
notify-device

 drivers/bluetooth/hci_mrvl.c                |  77 ++++++++++++--
 drivers/misc/Kconfig                        |   4 +
 drivers/misc/Makefile                       |   1 +
 drivers/misc/notify-device.c                | 109 ++++++++++++++++++++
 drivers/net/wireless/marvell/mwifiex/main.c |  14 +++
 drivers/net/wireless/marvell/mwifiex/main.h |   1 +
 include/linux/notify-device.h               |  33 ++++++
 7 files changed, 228 insertions(+), 11 deletions(-)
 create mode 100644 drivers/misc/notify-device.c
 create mode 100644 include/linux/notify-device.h
Signature · 1 line
2.25.1