Skip to content

btrfs: make send scale and perform better with shared extents

[email protected] linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18btrfs: fix inode list leak during backref walking at resolve_indirect_refs()fs/btrfs/backref.c+17 -190 replies
2/18btrfs: fix inode list leak during backref walking at find_parent_nodes()fs/btrfs/backref.c+17 -10 replies
3/18btrfs: fix ulist leaks in error paths of qgroup self testsfs/btrfs/tests/qgroup-tests.c+15 -50 replies
4/18btrfs: remove pointless and double ulist frees in error paths of qgroup testsfs/btrfs/tests/qgroup-tests.c+4 -120 replies
5/18btrfs: send: avoid unnecessary path allocations when finding extent clonefs/btrfs/send.c+16 -210 replies
6/18btrfs: send: update comment at find_extent_clone()fs/btrfs/send.c+7 -70 replies
7/18btrfs: send: drop unnecessary backref context field initializationsfs/btrfs/send.c+2 -30 replies
8/18btrfs: send: avoid unnecessary backref lookups when finding clone sourcefs/btrfs/send.c+10 -10 replies
9/18btrfs: send: optimize clone detection to increase extent sharingfs/btrfs/backref.c fs/btrfs/backref.h fs/btrfs/scrub.c +1 more+42 -240 replies
10/18btrfs: use a single argument for extent offset in backref walking functionsfs/btrfs/backref.c fs/btrfs/backref.h fs/btrfs/relocation.c +2 more+54 -510 replies
11/18btrfs: use a structure to pass arguments to backref walking functionsfs/btrfs/backref.c fs/btrfs/backref.h fs/btrfs/qgroup.c +4 more+328 -2270 replies
12/18btrfs: reuse roots ulist on each leaf iteration for iterate_extent_inodes()fs/btrfs/backref.c+31 -150 replies
13/18btrfs: constify ulist parameter of ulist_next()fs/btrfs/ulist.c fs/btrfs/ulist.h+2 -20 replies
14/18btrfs: send: cache leaf to roots mapping during backref walkingfs/btrfs/backref.c fs/btrfs/backref.h fs/btrfs/send.c+236 -120 replies
15/18btrfs: send: skip unnecessary backref iterationsfs/btrfs/backref.c fs/btrfs/backref.h fs/btrfs/send.c+128 -700 replies
16/18btrfs: send: avoid double extent tree search when finding clone sourcefs/btrfs/backref.c fs/btrfs/backref.h fs/btrfs/send.c+73 -700 replies
17/18btrfs: send: skip resolution of our own backref when finding clone sourcefs/btrfs/backref.c fs/btrfs/backref.h fs/btrfs/send.c+63 -140 replies
18/18btrfs: send: bump the extent reference count limit for backref walkingfs/btrfs/send.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/18] btrfs: make send scale and perform better with shared extents

From: Filipe Manana <[email protected]>

There are two problems with send regarding cloned extents:

1) Sometimes it ends up not cloning whole extents, but only a section of the extents, reducing in less extent sharing at the receiver and extra IO on the send side (reading data, issuing write commands) and on the receiver side too (writing more data). This is not only not optimal but it also surprises users and often gets reported (such as in the thread referenced in patch 09/18);

2) When we find that a data extent is directly shared more than 64 times, we don't attempt to clone it, because that requires backref walking to determine from which inode and range we should clone from and for extents with many backreferences, that can be too slow, specially if we have many thousands of extents with a huge amount of sharing each.

This patchset solves the first problem completely (patch 09/18), and for the second issue while not fully eliminated, it's significantly improved. In a test scenario with 50 000 files where each file is reflinked 50 times, there's a performance improvement of ~70% to ~75% for both full and incremental send operations. This test and results are in the changelog of patch 17/18.

After this we can now bump the limit from 64 max references to 1024, which is still a conservative value, but the goal is to get rid of such limit in the future (some more work required for that, but we're getting there).

There's also a nice and simple performance optimization when processing extents that are not shared and we are using only one clone source (the send root itself, very common), with gains varying between ~9% to ~18% in some small scale tests where there are no shared extents or the majority of the extents are not shared. That's patch 08/18.

The rest is just refactoring and cleanups in preparation for the optimization work for send, and a few bug fixes for error paths in the backref walking code and qgroup self tests. In particular the error paths for backref walking are important because with the latest patches they are triggered not just in case an error happens but also when the backref walking callbacks tell the backref walking code to stop early.

More details in the changelogs of the patches.

I've also left this in a git tree at:

https://git.kernel.org/pub/scm/linux/kernel/git/fdmanana/linux.git/log/?h=send_clone_performance_scalability

Filipe Manana (18):
btrfs: fix inode list leak during backref walking at resolve_indirect_refs()
btrfs: fix inode list leak during backref walking at find_parent_nodes()
btrfs: fix ulist leaks in error paths of qgroup self tests
btrfs: remove pointless and double ulist frees in error paths of qgroup tests
btrfs: send: avoid unnecessary path allocations when finding extent clone
btrfs: send: update comment at find_extent_clone()
btrfs: send: drop unnecessary backref context field initializations
btrfs: send: avoid unnecessary backref lookups when finding clone source
btrfs: send: optimize clone detection to increase extent sharing
btrfs: use a single argument for extent offset in backref walking functions
btrfs: use a structure to pass arguments to backref walking functions
btrfs: reuse roots ulist on each leaf iteration for iterate_extent_inodes()
btrfs: constify ulist parameter of ulist_next()
btrfs: send: cache leaf to roots mapping during backref walking
btrfs: send: skip unnecessary backref iterations
btrfs: send: avoid double extent tree search when finding clone source
btrfs: send: skip resolution of our own backref when finding clone source
btrfs: send: bump the extent reference count limit for backref walking

 fs/btrfs/backref.c            | 596 ++++++++++++++++++++--------------
 fs/btrfs/backref.h            | 137 +++++++-
 fs/btrfs/qgroup.c             |  38 ++-
 fs/btrfs/relocation.c         |  19 +-
 fs/btrfs/scrub.c              |  18 +-
 fs/btrfs/send.c               | 467 +++++++++++++++++++-------
 fs/btrfs/tests/qgroup-tests.c |  86 +++--
 fs/btrfs/ulist.c              |   2 +-
 fs/btrfs/ulist.h              |   2 +-
 9 files changed, 928 insertions(+), 437 deletions(-)
Signature · 1 line
2.35.1