Skip to content

RFC tests/kms_universal_plane: divide `functional_test_pipe` to mini-subtests

Alaa Emad igt-dev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest8 patches 2 repliesIn review
  2. v1 RFC8 patches 3 repliesSuperseded

Changes in v2 from the cover letter · 18 lines

add is_amdgpu_device() guard.
Alaa Emad (8):
tests/kms_universal_plane: decouple verification of legacy and atomic
api
tests/kms_universal_plane: decouple verification of disabling primary
plane
tests/kms_universal_plane: decouple verification of re-enabling
primary plane
tests/kms_universal_plane: decouple verification of setup plane FB's
while CRTC is disabled
tests/kms_universal_plane: decouple verification of ablity to modeset
with the primary plane off
tests/kms_universal_plane: decouple verification of ablity to move the
primary plane completely
tests/kms_universal_plane: decouple verification of ablity to
explicitly disable an already implicitly-disabled primary plane
tests/kms_universal_plane: create the run_functional_test_pipe and
call all tests from it

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8tests/kms_universal_plane: decouple verification of legacy and atomic apitests/kms_universal_plane.c+68 -00 replies
2/8tests/kms_universal_plane: decouple verification of disabling primary planetests/kms_universal_plane.c+70 -00 replies
3/8tests/kms_universal_plane: decouple verification of re-enabling primary planetests/kms_universal_plane.c+68 -00 replies
4/8tests/kms_universal_plane: decouple verification of setup plane FB's while CRTC is disabledtests/kms_universal_plane.c+94 -00 replies
5/8tests/kms_universal_plane: decouple verification of ablity to modeset with the primary plane offtests/kms_universal_plane.c+74 -00 replies
6/8tests/kms_universal_plane: decouple verification of ablity to move the primary plane completelytests/kms_universal_plane.c+97 -10 replies
7/8tests/kms_universal_plane: decouple verification of ablity to explicitly disable an already implicitly-disabled primary planetests/kms_universal_plane.c+94 -00 replies
8/8tests/kms_universal_plane: create the run_functional_test_pipe and call all tests from ittests/kms_universal_plane.c+166 -5981 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [igt-dev] [PATCH RFC i-g-t v2 0/8] tests/kms_universal_plane: divide `functional_test_pipe` to mini-subtests

Divide the functional_test_pipe test into seven subtests based on CRC comparisons because this will make it easier to debug the test and help in detecting the failure.

First 7 patches decouple each subtest and run it individually keeping functional_test_pipe' test as it is. After making sure that each subtest can run individually with the expected result on both vkms and i915 drivers, improve the test by creating run_functional_test_pipe and call all subtests from it and call run_functional_test_pipe in igt_main`.

-------
changes in v2:
add is_amdgpu_device() guard.
Alaa Emad (8):
tests/kms_universal_plane: decouple verification of legacy and atomic
api
tests/kms_universal_plane: decouple verification of disabling primary
plane
tests/kms_universal_plane: decouple verification of re-enabling
primary plane
tests/kms_universal_plane: decouple verification of setup plane FB's
while CRTC is disabled
tests/kms_universal_plane: decouple verification of ablity to modeset
with the primary plane off
tests/kms_universal_plane: decouple verification of ablity to move the
primary plane completely
tests/kms_universal_plane: decouple verification of ablity to
explicitly disable an already implicitly-disabled primary plane
tests/kms_universal_plane: create the run_functional_test_pipe and
call all tests from it

 tests/kms_universal_plane.c | 412 ++++++++++++++++++++++++------------
 1 file changed, 272 insertions(+), 140 deletions(-)
Signature · 1 line
2.34.1