Skip to content

bonding: fix bond recovery in mode 2

Jonathan Toppins linux-kselftest lkml netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyApplied 2/2
  2. v12 patches 8 repliesSuperseded

Changes in v2 from the cover letter

* repost to net tree, suggested by Paolo Abeni
* reduce number of icmp echos used in test, suggested by Paolo Abeni

Patches in v2 All 2 applied

#Subject and filesSizeRepliesApplied
1/2selftests: bonding: up/down delay w/ slave link flappingtools/testing/selftests/drivers/net/bonding/Makefile tools/testing/selftests/drivers/net/bonding/lag_lib.sh tools/testing/selftests/drivers/net/bonding/mode-1-recovery-updelay.sh +2 more+200 -20 repliesApplied
2/2bonding: fix link recovery in mode 2 when updelay is nonzerodrivers/net/bonding/bond_main.c+10 -11 replyApplied

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchJay Vosburgh
1/2
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net-next v2 0/2] bonding: fix bond recovery in mode 2

When a bond is configured with a non-zero updelay and in mode 2 the bond never recovers after all slaves lose link. The first patch adds selftests that demonstrate the issue and the second patch fixes the issue by ignoring the updelay when there are no usable slaves.

v2:
* repost to net tree, suggested by Paolo Abeni
* reduce number of icmp echos used in test, suggested by Paolo Abeni

Jonathan Toppins (2):
selftests: bonding: up/down delay w/ slave link flapping
bonding: fix link recovery in mode 2 when updelay is nonzero

 drivers/net/bonding/bond_main.c               |  11 +-
 .../selftests/drivers/net/bonding/Makefile    |   4 +-
 .../selftests/drivers/net/bonding/lag_lib.sh  | 106 ++++++++++++++++++
 .../net/bonding/mode-1-recovery-updelay.sh    |  45 ++++++++
 .../net/bonding/mode-2-recovery-updelay.sh    |  45 ++++++++
 .../selftests/drivers/net/bonding/settings    |   2 +-
 6 files changed, 210 insertions(+), 3 deletions(-)
 create mode 100755 tools/testing/selftests/drivers/net/bonding/mode-1-recovery-updelay.sh
 create mode 100755 tools/testing/selftests/drivers/net/bonding/mode-2-recovery-updelay.sh
Signature · 1 line
2.31.1