cxl: CXL Inject & Clear Poison
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest10 patches 5 repliesIn review
- v512 patches 22 repliesSuperseded
- v48 patches 2 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 8 patches | 6 replies | Superseded | |
| v2 | 6 patches | 16 replies | Superseded | |
| v1 | 5 patches | 19 replies | Superseded |
Changes in v6 from the cover letter
- Drop patches: The deprecate, and the removal of raw access, introduced for all poison commands in v13 of CXL Poison List Retrieval & Tracing, made these 2 patches obsolete:
cxl/memdev: Make inject and clear poison cmds kernel exclusive cxl/mbox: Block inject and clear poison opcodes in raw mode
- The device always writes the write data on Clear, regardless of whether or not the address is actually poisoned. Stop stating otherwise. (Jonathan)
- Update Patch 1 commit message to refer to CXL.mem driver (DaveJ)
- __cxl_dpa_to_region() Stop the walk on a match (Jonathan)
- Set & use cxlds->poison.enabled_cmds for inject & clear
- Simplify inject payload address assignment (DaveJ)
- Use down_read_interruptible in inject/clear
- Tidy up the memdev core api for inject/clear by using cxl_memdev
- Use the available cxl_memdev rather than dev in debugfs_create_file()
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | cxl/memdev: Add support for the Inject Poison mailbox commanddrivers/ drivers/ | +62 | 1 reply | |
| 2/10 | cxl/memdev: Add support for the Clear Poison mailbox commanddrivers/ drivers/ | +50 | 0 replies | |
| 3/10 | cxl/memdev: Warn of poison inject or clear to a mapped regiondrivers/ | +58 | 2 replies | |
| 4/10 | cxl/memdev: Trace inject and clear poison as cxl_poison eventsdrivers/ drivers/ drivers/ | +22 | 0 replies | |
| 5/10 | cxl/mem: Add debugfs attributes for poison inject and clearDocumentation/ drivers/ | +63 | 0 replies | |
| 6/10 | tools/testing/cxl: Mock the Inject Poison mailbox commandtools/ | +77 | 0 replies | |
| 7/10 | tools/testing/cxl: Mock the Clear Poison mailbox commandtools/ | +36 | 0 replies | |
| 8/10 | tools/testing/cxl: Use injected poison for get poison listtools/ | +40 | 1 reply | |
| 9/10 | tools/testing/cxl: Add a sysfs attr to test poison inject limitstools/ | +48 | 0 replies | |
| 10/10 | tools/testing/cxl: Require CONFIG_DEBUG_FStools/ | +1 | 0 replies |
Reviews trailers per patch
All 10 patches have a Reviewed-by or Acked-by.
| Patch | Jonathan Cameron | Dave Jiang |
|---|---|---|
| Series | T-b | |
| 1/10 | R-b | R-b |
| 2/10 | R-b | |
| 3/10 | R-b | |
| 4/10 | R-b | R-b |
| 5/10 | R-b | |
| 6/10 | R-b | |
| 7/10 | R-b | R-b |
| 8/10 | R-b | |
| 9/10 | R-b | |
| 10/10 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v6 0/10] cxl: CXL Inject & Clear Poison
From: Alison Schofield <[email protected]>
Built on cxl/next plus [PATCH v13 0/9] CXL Poison List Retrieval & Tracing
https://lore.kernel.org/linux-cxl/[email protected]/
Changes in v6:
- Drop patches: The deprecate, and the removal of raw access, introduced for all poison commands in v13 of CXL Poison List Retrieval & Tracing, made these 2 patches obsolete:
cxl/memdev: Make inject and clear poison cmds kernel exclusive cxl/mbox: Block inject and clear poison opcodes in raw mode
- The device always writes the write data on Clear, regardless of whether or not the address is actually poisoned. Stop stating otherwise. (Jonathan)
- Update Patch 1 commit message to refer to CXL.mem driver (DaveJ)
- __cxl_dpa_to_region() Stop the walk on a match (Jonathan)
- Set & use cxlds->poison.enabled_cmds for inject & clear
- Simplify inject payload address assignment (DaveJ)
- Use down_read_interruptible in inject/clear
- Tidy up the memdev core api for inject/clear by using cxl_memdev
- Use the available cxl_memdev rather than dev in debugfs_create_file()
Link to v5:
https://lore.kernel.org/linux-cxl/[email protected]/
Introducing Inject and Clear Poison support for CXL Devices.
These are optional commands, meaning not all CXL devices must support them. The debugfs attributes, inject_poison and clear_poison, are only visible for devices reporting support of the capability.
Example:
# echo 0x40000000 > /sys/kernel/debug/cxl/mem1/inject_poison
cxl_poison: memdev=mem1 pcidev=cxl_mem.1 trace_type=Inject region= region_uuid=00000000-0000-0000-0000-000000000000 hpa=0xffffffffffffffff dpa=0x40000000 dpa_length=0x40 source=Unknown flags= overflow_time=0
Example in which the injected poison landed in region5:
# echo 0x40000000 > /sys/kernel/debug/cxl/mem0/inject_poison
cxl_poison: memdev=mem0 host=cxl_mem.0 serial=0 trace_type=Inject region=region5 region_uuid=cfcfc13a-5290-4983-aa74-4c8465c25f26 hpa=0xf110000000 dpa=0x40000000 dpa_length=0x40 source=Unknown flags= overflow_time=0
Alison Schofield (10):
cxl/memdev: Add support for the Inject Poison mailbox command cxl/memdev: Add support for the Clear Poison mailbox command cxl/memdev: Warn of poison inject or clear to a mapped region cxl/memdev: Trace inject and clear poison as cxl_poison events cxl/mem: Add debugfs attributes for poison inject and clear tools/testing/cxl: Mock the Inject Poison mailbox command tools/testing/cxl: Mock the Clear Poison mailbox command tools/testing/cxl: Use injected poison for get poison list tools/testing/cxl: Add a sysfs attr to test poison inject limits tools/testing/cxl: Require CONFIG_DEBUG_FS
Documentation/ABI/testing/debugfs-cxl | 35 +++++ drivers/cxl/core/core.h | 2 + drivers/cxl/core/memdev.c | 172 ++++++++++++++++++++ drivers/cxl/core/trace.h | 8 +- drivers/cxl/cxlmem.h | 13 ++ drivers/cxl/mem.c | 28 ++++ tools/testing/cxl/config_check.c | 1 + tools/testing/cxl/test/mem.c | 216 +++++++++++++++++++++++--- 8 files changed, 453 insertions(+), 22 deletions(-) create mode 100644 Documentation/ABI/testing/debugfs-cxl
Signature · 1 line
2.37.3