Skip to content

Support custom contexts in exec_blit()

Karolina Stolarek igt-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2lib/intel_batchbuffer: Make find_engine() more flexiblelib/intel_batchbuffer.c+3 -52 replies
2/2lib/intel_batchbuffer: Use correct engine id in exec_blit()lib/igt_fb.c lib/intel_batchbuffer.c lib/intel_batchbuffer.h +2 more+48 -322 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchZbigniew Kempczyński
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [igt-dev] [PATCH i-g-t 0/2] Support custom contexts in exec_blit()

The series changes how exec_blit() sets blitter engine id in execbuf used by igt_blitter_src_copy() and igt_blitter_fast_copy__raw(). Currently, the function assumes a legacy engine identifier, which won't work for contexts that have non-standard engine layout.

With this patch series, it will be possible to find a copy engine based on intel_ctx_cfg_t passed in by the blitter copy functions. To make it possible, find_engine() had to be slightly modified. Here, instead of using intel_bb (which limits the function usage to this structure only), we use context config extracted from intel_bb, making find_engine() more flexible.

Karolina Stolarek (2):
lib/intel_batchbuffer: Make find_engine() more flexible lib/intel_batchbuffer: Use correct engine id in exec_blit()

 lib/igt_fb.c            |  4 +--
 lib/intel_batchbuffer.c | 60 ++++++++++++++++++++++++-----------------
 lib/intel_batchbuffer.h |  2 ++
 tests/kms_prime.c       |  6 +++--
 tests/prime_vgem.c      | 14 +++++-----
 5 files changed, 50 insertions(+), 36 deletions(-)

--
2.25.1