Skip to content

feat: checkpatch: warn about dicouraged link tags and missing links

Kai Wasserbäch lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest3 patches 2 repliesIn review

Changes in v3 from the cover letter

- address review feedback from Joe (grammer fixes, use of $herecurr, use of --no-merges in commit log quote) (Thorsten)
- warn when people try to add version information to the commit log using code suggested by Joe (Thorsten)
- add a patch to make existing code in a nearby area use $herecurr where it should, which Joe noticed during review

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3checkpatch: warn when unknown tags are used for linksscripts/checkpatch.pl+12 -00 replies
2/3checkpatch: warn when Reported-by: is not followed by Link:scripts/checkpatch.pl+14 -02 replies
3/3checkpatch: use proper way for show problematic linescripts/checkpatch.pl+4 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH 0/3, v3] feat: checkpatch: warn about dicouraged link tags and missing links

Hey,
Thorsten Leemhuis suggested the following two changes to checkpatch, which I hereby humbly submit for review. Please let me know if any changes would be required for acceptance.

The third patch came out of the preview rounds and fixes an odd behaviour noticed then.

The two main changes should help developers write commit messages in a way that's preferred by Linus and will greatly help Thorsten's regression tracking efforts.

Patches are against mm/mm-nonmm-stable (which apparently is the tree checkpatch changes are merged through).

Cheers,
Kai

v2->v3:
- address review feedback from Joe (grammer fixes, use of $herecurr, use of --no-merges in commit log quote) (Thorsten)
- warn when people try to add version information to the commit log using code suggested by Joe (Thorsten)
- add a patch to make existing code in a nearby area use $herecurr where it should, which Joe noticed during review

v1->v2:
- add commit messages explaining the reasoning (Thorsten)
- approach the usage of wrong tags with an allow list as suggested by Joe (Thorsten)

Kai Wasserbäch (2):
checkpatch: warn when unknown tags are used for links
checkpatch: warn when Reported-by: is not followed by Link:

Thorsten Leemhuis (1):
checkpatch: use proper way for show problematic line

 scripts/checkpatch.pl | 34 ++++++++++++++++++++++++++++++----
 1 file changed, 30 insertions(+), 4 deletions(-)
Signature · 1 line
2.35.1