Fixup uninitialized warnings and enable extra checks
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest8 patches 35 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | btrfs: fix uninit warning in run_one_async_startfs/ | +1 | 4 replies | |
| 2/8 | btrfs: fix uninit warning in btrfs_cleanup_ordered_extentsfs/ | +1 | 2 replies | |
| 3/8 | btrfs: fix uninit warning from get_inode_gen usagefs/ | +3 | 3 replies | |
| 4/8 | btrfs: fix uninit warning in btrfs_update_block_groupfs/ | +1 | 2 replies | |
| 5/8 | btrfs: fix uninit warning in __set_extent_bit and convert_extent_bitfs/ | +4 | 1 reply | |
| 6/8 | btrfs: extract out zone cache usage into it's own helperfs/ | +45 | 4 replies | |
| 7/8 | btrfs: fix uninit warning in btrfs_sb_log_locationfs/ | +1 | 2 replies | |
| 8/8 | btrfs: turn on -Wmaybe-uninitializedfs/ | +1 | 13 replies |
Reviews trailers per patch
7 of 8 patches have a Reviewed-by or Acked-by.
| Patch | Qu Wenruo | Naohiro Aota | Johannes Thumshirn |
|---|---|---|---|
| 1/8 | R-b | ||
| 2/8 | R-b | R-b | |
| 3/8 | R-b | R-b | |
| 4/8 | R-b | R-b | |
| 5/8 | R-b | ||
| 6/8 | |||
| 7/8 | R-b | R-b | |
| 8/8 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH 0/8] Fixup uninitialized warnings and enable extra checks
Hello,
We had been failing the raid56 related scrub tests on our overnight tests since November. Initially I asked Qu to look into these as I didn't have time to dig in, and he was unable to reproduce. I assumed it was some oddity in my setup, so I ignored it. However recently I got a report that I regressed some of these tests with an unrelated change. When debugging it I found it was because of an uninitialized return value, which would have been caught by more modern gcc's with -Wmaybe-uninitialized.
In order to avoid these sort of problems in the future lets fix up all the false positivies that this warning brings, and then enable the option for btrfs so we can avoid this style of failure in the future. Thanks,
Josef
Josef Bacik (8):
btrfs: fix uninit warning in run_one_async_start
btrfs: fix uninit warning in btrfs_cleanup_ordered_extents
btrfs: fix uninit warning from get_inode_gen usage
btrfs: fix uninit warning in btrfs_update_block_group
btrfs: fix uninit warning in __set_extent_bit and convert_extent_bit
btrfs: extract out zone cache usage into it's own helper
btrfs: fix uninit warning in btrfs_sb_log_location
btrfs: turn on -Wmaybe-uninitialized
fs/btrfs/Makefile | 1 + fs/btrfs/block-group.c | 2 +- fs/btrfs/disk-io.c | 2 +- fs/btrfs/extent-io-tree.c | 8 ++--- fs/btrfs/inode.c | 2 +- fs/btrfs/send.c | 8 ++--- fs/btrfs/zoned.c | 75 ++++++++++++++++++++++++--------------- 7 files changed, 57 insertions(+), 41 deletions(-)
Signature · 1 line
2.26.3