bpf: Add socket destroy capability
Status from this message: This series was applied to bpf/bpf-next.git (master)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v9 Latest9 patches 7 repliesApplied 9/9
- v810 patches 7 repliesSuperseded
- v710 patches 7 repliesSuperseded
Earlier versions · 7
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v6 | 7 patches | 18 replies | Superseded | |
| v5 | 7 patches | 16 replies | Superseded | |
| v4 posting 2/2 | 4 patches | 24 replies | Superseded | |
| v4 posting 1/2 | 0 of 5 patches | 0 replies | Superseded | |
| v3 | 5 patches | 19 replies | Superseded | |
| v2 | 3 patches | 20 replies | Superseded | |
| v1 | 2 patches | 11 replies | Superseded |
v8 patch series - from the cover letter
Patches in v9 All 9 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | bpf: tcp: Avoid taking fast sock lock in iteratornet/ | +2 | 0 replies | Applied |
| 2/9 | udp: seq_file: Helper function to match socket attributesnet/ | +27 | 0 replies | Applied |
| 3/9 | bpf: udp: Encapsulate logic to get udp tablenet/ | +12 | 0 replies | Applied |
| 4/9 | udp: seq_file: Remove bpf_seq_afinfo from udp_iter_stateinclude/ net/ | +7 | 0 replies | Applied |
| 5/9 | bpf: udp: Implement batching for sockets iteratornet/ | +199 | 7 replies | Applied |
| 6/9 | bpf: Add kfunc filter function to 'struct btf_kfunc_id_set'include/ kernel/ kernel/ | +66 | 0 replies | Applied |
| 7/9 | bpf: Add bpf_sock_destroy kfuncnet/ net/ net/ +1 more | +75 | 0 replies | Applied |
| 8/9 | selftests/bpf: Add helper to get port using getsocknametools/ tools/ | +24 | 0 replies | Applied |
| 9/9 | selftests/bpf: Test bpf_sock_destroytools/ tools/ tools/ | +388 | 0 replies | Applied |
Reviews trailers per patch
1 of 9 patches has a Reviewed-by or Acked-by.
| Patch | Yonghong Song | Stanislav Fomichev |
|---|---|---|
| 1/9 | A-b | A-b |
| 2/9 | ||
| 3/9 | ||
| 4/9 | ||
| 5/9 | ||
| 6/9 | ||
| 7/9 | ||
| 8/9 | ||
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v9 bpf-next 0/9] bpf: Add socket destroy capability
This patch set adds the capability to destroy sockets in BPF. We plan to use the capability in Cilium to force client sockets to reconnect when their remote load-balancing backends are deleted. The other use case is on-the-fly policy enforcement where existing socket connections prevented by policies need to be terminated.
The use cases, and more details around
the selected approach were presented at LPC 2022 -
https://lpc.events/event/16/contributions/1358/.
RFC discussion -
https://lore.kernel.org/netdev/CABG=zsBEh-P4NXk23eBJw7eajB5YJeRS7oPXnTAzs=yob4EMoQ@mail.gmail.com/T/#u.
v8 patch series -
https://lore.kernel.org/bpf/[email protected]/
v9 highlights:
Address review comments:
Martin:
- Rearranged the kfunc filter patch, and added the missing break statement.
- Squashed the extended selftest/bpf patch.
Yonghong:
- Revised commit message for patch 1.
(Below notes are same as v8 patch series that are still relevant. Refer to earlier patch series versions for other notes.)
- I hit a snag while writing the kfunc where verifier complained about the sock_common type passed from TCP iterator. With kfuncs, there don't seem to be any options available to pass BTF type hints to the verifier (equivalent of ARG_PTR_TO_BTF_ID_SOCK_COMMON, as was the case with the helper). As a result, I changed the argument type of the sock_destory kfunc to sock_common.
Aditi Ghag (9):
bpf: tcp: Avoid taking fast sock lock in iterator
udp: seq_file: Helper function to match socket attributes
bpf: udp: Encapsulate logic to get udp table
udp: seq_file: Remove bpf_seq_afinfo from udp_iter_state
bpf: udp: Implement batching for sockets iterator
bpf: Add kfunc filter function to 'struct btf_kfunc_id_set'
bpf: Add bpf_sock_destroy kfunc
selftests/bpf: Add helper to get port using getsockname selftests/bpf: Test bpf_sock_destroy
include/linux/btf.h | 18 +- include/net/udp.h | 1 - kernel/bpf/btf.c | 61 +++- kernel/bpf/verifier.c | 7 +- net/core/filter.c | 63 ++++ net/ipv4/tcp.c | 9 +- net/ipv4/tcp_ipv4.c | 7 +- net/ipv4/udp.c | 291 +++++++++++++++--- tools/testing/selftests/bpf/network_helpers.c | 23 ++ tools/testing/selftests/bpf/network_helpers.h | 1 + .../selftests/bpf/prog_tests/sock_destroy.c | 221 +++++++++++++ .../selftests/bpf/progs/sock_destroy_prog.c | 145 +++++++++ .../bpf/progs/sock_destroy_prog_fail.c | 22 ++ 13 files changed, 791 insertions(+), 78 deletions(-) create mode 100644 tools/testing/selftests/bpf/prog_tests/sock_destroy.c create mode 100644 tools/testing/selftests/bpf/progs/sock_destroy_prog.c create mode 100644 tools/testing/selftests/bpf/progs/sock_destroy_prog_fail.c
Signature · 1 line
2.34.1