btrfs: add error reports for possible run_one_delayed_ref()
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | btrfs: add extra error message for tree block level mismatchfs/ | +4 | 1 reply | |
| 2/2 | btrfs: always report error for run_one_delayed_ref()fs/ | +5 | 2 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Anand Jain |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] btrfs: add error reports for possible run_one_delayed_ref()
There is a bug report that one can cause error in run_one_delayed_ref() and make the fs RO.
But there is only two lines of dmesg:
BTRFS: error (device nvme0n1p3: state A) in btrfs_run_delayed_refs:2147: errno=-5 IO failure BTRFS info (device nvme0n1p3: state EA): forced readonly
Which is not really helpful.
This patch will add two error reports which should help us to debug:
- Add the missing level check errors in validate_extent_buffer() Failed level checks didn't cause any error message, which is very different compared to the other checks.
- Add error report for failed run_one_delayed_ref() This will include extra info for each node.
The remaining branches are either calling btrfs_abort_transaction(), which should provide function and line number, or have extra error message like alloc_reserved_extent(), or should trigger error messages from validate_extent_buffer() when failed, like btrfs_insert_empty_item().
Thus this two patches should cover most of the error cases.
Qu Wenruo (2):
btrfs: add extra error message for tree block level mismatch
btrfs: always report error for run_one_delayed_ref()
fs/btrfs/disk-io.c | 4 ++++ fs/btrfs/extent-tree.c | 7 +++++-- 2 files changed, 9 insertions(+), 2 deletions(-)
Signature · 1 line
2.39.0