Skip to content

Provide more error details when a QP moves to error state

Leon Romanovsky linux-rdma lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Changes in v1 from the cover letter

* Reworked mlx4 to allow non-atomic IB QP event handler.
v0: https://lore.kernel.org/linux-rdma/[email protected]/

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3RDMA/mlx: Calling qp event handler in workqueue contextdrivers/infiniband/hw/mlx4/main.c drivers/infiniband/hw/mlx4/mlx4_ib.h drivers/infiniband/hw/mlx4/qp.c +7 more+202 -780 replies
2/3net/mlx5: Introduce CQE error syndromeinclude/linux/mlx5/mlx5_ifc.h+42 -51 reply
3/3RDMA/mlx5: Print error syndrome in case of fatal QP errorsdrivers/infiniband/hw/mlx5/qp.c drivers/infiniband/hw/mlx5/qp.h drivers/infiniband/hw/mlx5/qpc.c+48 -31 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchPatrisious HaddadSaeed Mahameed
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH rdma-next v1 0/3] Provide more error details when a QP moves to error state

From: Leon Romanovsky <[email protected]>

Changelog:
v1:
* Reworked mlx4 to allow non-atomic IB QP event handler.
v0: https://lore.kernel.org/linux-rdma/[email protected]/

------------------------------------------
The following series adds ability to get information about fatal QP events.

This functionality is extremely useful for the following reasons:
* Provides an information about the reason why QP moved to error state, in cases where CQE isn't generated.
* Allows to provide vendor specfic error codes and information that could be very useful to users who know them.

An example of a case without CQE is a remote write with RKEY violation. In this flow, on remote side no CQEs are generated and such error without indication is hard to debug.

Thanks.

Mark Zhang (1):
RDMA/mlx: Calling qp event handler in workqueue context

Patrisious Haddad (2):
net/mlx5: Introduce CQE error syndrome RDMA/mlx5: Print error syndrome in case of fatal QP errors

 drivers/infiniband/hw/mlx4/main.c       |   8 ++
 drivers/infiniband/hw/mlx4/mlx4_ib.h    |   3 +
 drivers/infiniband/hw/mlx4/qp.c         | 121 +++++++++++------
 drivers/infiniband/hw/mlx5/main.c       |   7 +
 drivers/infiniband/hw/mlx5/qp.c         | 164 ++++++++++++++++++------
 drivers/infiniband/hw/mlx5/qp.h         |   4 +-
 drivers/infiniband/hw/mlx5/qpc.c        |   7 +-
 drivers/net/ethernet/mellanox/mlx4/qp.c |  14 +-
 include/linux/mlx4/qp.h                 |   1 +
 include/linux/mlx5/mlx5_ifc.h           |  47 ++++++-
 include/rdma/ib_verbs.h                 |   2 +-
 11 files changed, 292 insertions(+), 86 deletions(-)
Signature · 1 line
2.38.1