Skip to content

ezchip: Simplify some code

Christophe JAILLET kernel-janitors lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ezchip: Remove some redundant clean-up functionsdrivers/net/ethernet/ezchip/nps_enet.c+0 -21 reply
2/3ezchip: Switch to some devm_ function to simplify codedrivers/net/ethernet/ezchip/nps_enet.c+9 -334 replies
3/3ezchip: Further clean-updrivers/net/ethernet/ezchip/nps_enet.c+1 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/3] ezchip: Simplify some code

Theses patches (at least 1 and 2) can be seen as an RFC for net MAINTAINERS get see if they see any interest in:
- axing useless netif_napi_del() calls, when free_netdev() is called just after. (patch 1)
- simplifying code with axing the error handling path of the probe and the remove function in favor of using devm_ functions (patch 2)

or

if it doesn't not worth it and MAINTAINERS' time can be focused on more interesting topics than checking what is in fact only code clean-ups.

The rational for patch 1 is based on Jakub's comment [1]. free_netdev() already cleans up NAPIs (see [2]).

CJ

[1]: https://lore.kernel.org/all/[email protected]/
[2]: https://elixir.bootlin.com/linux/v6.2-rc1/source/net/core/dev.c#L10710

Christophe JAILLET (3):
ezchip: Remove some redundant clean-up functions
ezchip: Switch to some devm_ function to simplify code
ezchip: Further clean-up

 drivers/net/ethernet/ezchip/nps_enet.c | 47 ++++++--------------------
 1 file changed, 10 insertions(+), 37 deletions(-)
Signature · 1 line
2.34.1