Skip to content

btrfs: some optimizations for send

[email protected] linux-btrfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest18 patches 1 replyIn review
  2. v119 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18btrfs: send: directly return from did_overwrite_ref() and simplify itfs/btrfs/send.c+18 -250 replies
2/18btrfs: send: avoid unnecessary generation search at did_overwrite_ref()fs/btrfs/send.c+22 -90 replies
3/18btrfs: send: directly return from will_overwrite_ref() and simplify itfs/btrfs/send.c+16 -220 replies
4/18btrfs: send: avoid extra b+tree searches when checking reference overridesfs/btrfs/send.c+29 -320 replies
5/18btrfs: send: remove send_progress argument from can_rmdir()fs/btrfs/send.c+5 -80 replies
6/18btrfs: send: avoid duplicated orphan dir allocation and initializationfs/btrfs/send.c+12 -150 replies
7/18btrfs: send: avoid unnecessary orphan dir rbtree search at can_rmdir()fs/btrfs/send.c+7 -40 replies
8/18btrfs: send: reduce searches on parent root when checking if dir can be removedfs/btrfs/send.c+59 -60 replies
9/18btrfs: send: iterate waiting dir move rbtree only once when processing refsfs/btrfs/send.c+2 -50 replies
10/18btrfs: send: initialize all the red black trees earlierfs/btrfs/send.c+6 -60 replies
11/18btrfs: send: genericize the backref cache to allow it to be reusedfs/btrfs/Makefile fs/btrfs/lru_cache.c fs/btrfs/lru_cache.h +1 more+167 -570 replies
12/18btrfs: adapt lru cache to allow for 64 bits keys on 32 bits systemsfs/btrfs/lru_cache.c fs/btrfs/lru_cache.h+83 -150 replies
13/18btrfs: send: cache information about created directoriesfs/btrfs/send.c+40 -10 replies
14/18btrfs: allow a generation number to be associated with lru cache entriesfs/btrfs/lru_cache.c fs/btrfs/lru_cache.h fs/btrfs/send.c+20 -90 replies
15/18btrfs: add an api to delete a specific entry from the lru cachefs/btrfs/lru_cache.c fs/btrfs/lru_cache.h+14 -40 replies
16/18btrfs: send: use the lru cache to implement the name cachefs/btrfs/send.c+24 -1400 replies
17/18btrfs: send: update size of roots array for backref cache entriesfs/btrfs/send.c+8 -70 replies
18/18btrfs: send: cache utimes operations for directories if possiblefs/btrfs/lru_cache.h fs/btrfs/send.c+91 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/18] btrfs: some optimizations for send

From: Filipe Manana <[email protected]>

This adds some optimizations for send and some cleanups, mostly around processing directories. Some of the cleanups are independent.

More details in the individual changelogs, and the last one contains results for a performance test.

V2: Dropped the patch that added the use of MT_FLAGS_LOCK_EXTERN,
it turns out it does not work how I expected it to, see:
https://lore.kernel.org/linux-btrfs/[email protected]/

Filipe Manana (18):
btrfs: send: directly return from did_overwrite_ref() and simplify it
btrfs: send: avoid unnecessary generation search at did_overwrite_ref()
btrfs: send: directly return from will_overwrite_ref() and simplify it
btrfs: send: avoid extra b+tree searches when checking reference overrides
btrfs: send: remove send_progress argument from can_rmdir()
btrfs: send: avoid duplicated orphan dir allocation and initialization
btrfs: send: avoid unnecessary orphan dir rbtree search at can_rmdir()
btrfs: send: reduce searches on parent root when checking if dir can be removed
btrfs: send: iterate waiting dir move rbtree only once when processing refs
btrfs: send: initialize all the red black trees earlier
btrfs: send: genericize the backref cache to allow it to be reused
btrfs: adapt lru cache to allow for 64 bits keys on 32 bits systems
btrfs: send: cache information about created directories
btrfs: allow a generation number to be associated with lru cache entries
btrfs: add an api to delete a specific entry from the lru cache
btrfs: send: use the lru cache to implement the name cache
btrfs: send: update size of roots array for backref cache entries
btrfs: send: cache utimes operations for directories if possible

 fs/btrfs/Makefile    |   3 +-
 fs/btrfs/lru_cache.c | 163 +++++++++++
 fs/btrfs/lru_cache.h |  80 ++++++
 fs/btrfs/send.c      | 645 ++++++++++++++++++++++---------------------
 4 files changed, 572 insertions(+), 319 deletions(-)
 create mode 100644 fs/btrfs/lru_cache.c
 create mode 100644 fs/btrfs/lru_cache.h
Signature · 1 line
2.35.1