Skip to content

mptcp: refactor first subflow init

Paolo Abeni mptcp 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest15 patches 6 repliesIn review
  2. v213 patches 11 repliesSuperseded
  3. v19 patches 2 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15mptcp: use mptcp_schedule_work() instead of open-codying itnet/mptcp/subflow.c+2 -70 replies
2/15mptcp: fix locking for setsockopt corner-casenet/mptcp/sockopt.c+9 -20 replies
3/15mptcp: fix locking for in-kernel listener creation.net/mptcp/pm_netlink.c net/mptcp/subflow.c+7 -50 replies
4/15mptcp: refactor passive socket initialization.net/mptcp/protocol.c net/mptcp/subflow.c+24 -240 replies
5/15mptcp: drop unneeded argumentnet/mptcp/options.c net/mptcp/pm.c net/mptcp/protocol.h +1 more+5 -50 replies
6/15mptcp: drop legacy code.net/mptcp/options.c net/mptcp/subflow.c+4 -100 replies
7/15mptcp: avoid unneeded __mptcp_nmpc_socket() usagenet/mptcp/protocol.c+6 -30 replies
8/15mptcp: move fastopen subflow check inside mptcp_sendmsg_fastopen()net/mptcp/protocol.c+18 -60 replies
9/15mptcp: move first subflow allocation at mpc access timenet/mptcp/pm_netlink.c net/mptcp/protocol.c net/mptcp/protocol.h +1 more+53 -361 reply
10/15mptcp: do not keep around the first subflow after disconnect.net/mptcp/protocol.c+5 -190 replies
11/15mptcp: fastclose msk when cleaning unaccepted socketsnet/mptcp/protocol.c net/mptcp/subflow.c+6 -30 replies
12/15inet: factor out locked section of inet_accept() in a new helperinclude/net/inet_common.h net/ipv4/af_inet.c+19 -150 replies
13/15mptcp: refactor mptcp_stream_accept()net/mptcp/protocol.c+12 -80 replies
14/15security, lsm: Introduce security_mptcp_add_subflow()include/linux/lsm_hook_defs.h include/linux/lsm_hooks.h include/linux/security.h +2 more+27 -00 replies
15/15selinux: Implement mptcp_add_subflow hooksecurity/selinux/hooks.c security/selinux/netlabel.c+22 -23 replies

Reviews trailers per patch

None of the 15 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMatthieu Baerts
SeriesR-b
1/15
2/15
3/15
4/15
5/15
6/15
7/15
8/15
9/15
10/15
11/15
12/15
13/15
14/15
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 mptcp-next 00/15] mptcp: refactor first subflow init

This is the needed refactor for the selinux fixes, as discussed on the ML.

Compared to v2 this revision introduces 2 additional patches:
1/15, just another cleanup found while addressing the recent bugs 12/15 factoring out a __inet_listener() helper, as suggested by Mat.

The only other patches with some change is 9/15, adding more comments and consistently reporting the newly introduced error code (a bit different from what discussed on the ML, for consistency's sake).

Paolo Abeni (15):
mptcp: use mptcp_schedule_work() instead of open-codying it
mptcp: fix locking for setsockopt corner-case
mptcp: fix locking for in-kernel listener creation.
mptcp: refactor passive socket initialization.
mptcp: drop unneeded argument
mptcp: drop legacy code.
mptcp: avoid unneeded __mptcp_nmpc_socket() usage
mptcp: move fastopen subflow check inside mptcp_sendmsg_fastopen()
mptcp: move first subflow allocation at mpc access time
mptcp: do not keep around the first subflow after disconnect.
mptcp: fastclose msk when cleaning unaccepted sockets
inet: factor out locked section of inet_accept() in a new helper
mptcp: refactor mptcp_stream_accept()
security, lsm: Introduce security_mptcp_add_subflow()
selinux: Implement mptcp_add_subflow hook

 include/linux/lsm_hook_defs.h |   1 +
 include/linux/lsm_hooks.h     |   9 ++
 include/linux/security.h      |   6 ++
 include/net/inet_common.h     |   2 +
 net/ipv4/af_inet.c            |  32 +++----
 net/mptcp/options.c           |   9 +-
 net/mptcp/pm.c                |   4 +-
 net/mptcp/pm_netlink.c        |  14 +--
 net/mptcp/protocol.c          | 158 +++++++++++++++++-----------------
 net/mptcp/protocol.h          |   4 +-
 net/mptcp/sockopt.c           |  31 ++++---
 net/mptcp/subflow.c           |  57 +++++++-----
 security/security.c           |   5 ++
 security/selinux/hooks.c      |  16 ++++
 security/selinux/netlabel.c   |   8 +-
 15 files changed, 215 insertions(+), 141 deletions(-)
Signature · 1 line
2.39.1