Skip to content

Remove several variables that are zero from struct r8192_priv

Philipp Hortmann linux-staging lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6staging: rtl8192e: Combine three loops to one to init tx_pwr_level_...drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c+1 -210 replies
2/6staging: rtl8192e: Init tx_pwr_level_cck_a and friends directlydrivers/staging/rtl8192e/rtl8192e/r8192E_dev.c drivers/staging/rtl8192e/rtl8192e/rtl_core.h+4 -120 replies
3/6staging: rtl8192e: Remove zeroed arrays tx_pwr_level_cck_a and friendsdrivers/staging/rtl8192e/rtl8192e/r8192E_dev.c drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/rtl_core.h+5 -170 replies
4/6staging: rtl8192e: Remove ant_pwr_diff which is always zerodrivers/staging/rtl8192e/rtl8192e/r8192E_phy.c+1 -60 replies
5/6staging: rtl8192e: Remove u4RegValue which is always zerodrivers/staging/rtl8192e/rtl8192e/r8192E_phy.c+1 -70 replies
6/6staging: rtl8192e: Remove repeated set to zero of powerlevel and frienddrivers/staging/rtl8192e/rtl8192e/r8192E_phy.c+1 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] Remove several variables that are zero from struct r8192_priv

The arrays EEPROMRfACCKChnl1TxPwLevel, EEPROMRfAOfdmChnlTxPwLevel, EEPROMRfCCCKChnl1TxPwLevel, EEPROMRfCOfdmChnlTxPwLevel are initialized to zero and never changed. These arrays are used to initialize other variables that are then also zero. Remove several variables set to zero to avoid camelCase and to remove dead code.

Tested with rtl8192e (But most of this code is not executed on my hardware) Transferred this patch over wlan connection of rtl8192e

Philipp Hortmann (6):
staging: rtl8192e: Combine three loops to one to init tx_pwr_level_...
staging: rtl8192e: Init tx_pwr_level_cck_a and friends directly
staging: rtl8192e: Remove zeroed arrays tx_pwr_level_cck_a and friends
staging: rtl8192e: Remove ant_pwr_diff which is always zero
staging: rtl8192e: Remove u4RegValue which is always zero
staging: rtl8192e: Remove repeated set to zero of powerlevel and
friend

 .../staging/rtl8192e/rtl8192e/r8192E_dev.c    | 31 -------------------
 .../staging/rtl8192e/rtl8192e/r8192E_phy.c    | 24 ++------------
 drivers/staging/rtl8192e/rtl8192e/rtl_core.h  |  8 -----
 3 files changed, 3 insertions(+), 60 deletions(-)
Signature · 1 line
2.39.0