Skip to content

Collection of DOE material

Lukas Wunner linux-cxl linux-pci 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest17 patches 7 repliesIn review
  2. v316 patches 45 repliesSuperseded
  3. v210 patches 42 repliesSuperseded

Changes in v4 from the cover letter

* [PATCH v4 01/17] cxl/pci: Fix CDAT retrieval on big endian
* In pci_doe_discovery(), add request_pl_le / response_pl_le variables to avoid typecasts in pci_doe_task initializer (Jonathan)
* In cxl_cdat_read_table(), use __le32 instead of u32 for "*data" variable (Jonathan)
* Use sizeof(__le32) instead of sizeof(u32) (Jonathan)

* [PATCH v4 03/17] cxl/pci: Handle truncated CDAT entries
* Check for sizeof(*entry) instead of sizeof(struct cdat_entry_header) for clarity (Jonathan)

* [PATCH v4 12/17] PCI/DOE: Create mailboxes on device enumeration
* Amend commit message with additional justification for the commit (Alexey)

* [PATCH v4 16/17] cxl/pci: cxl/pci: Simplify CDAT retrieval error path
* Newly added patch in v4 on popular request (Jonathan, Dave)

* [PATCH v4 17/17] cxl/pci: Rightsize CDAT response allocation
* Amend commit message with spec reference to the Table Access Response Header (Ira)
* In cxl_cdat_get_length(), check for sizeof(response) instead of 2 * sizeof(u32) for clarity

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17cxl/pci: Fix CDAT retrieval on big endiandrivers/cxl/core/pci.c drivers/pci/doe.c include/linux/pci-doe.h+33 -261 reply
2/17cxl/pci: Handle truncated CDAT headerdrivers/cxl/core/pci.c+1 -11 reply
3/17cxl/pci: Handle truncated CDAT entriesdrivers/cxl/core/pci.c drivers/cxl/cxlpci.h+23 -40 replies
4/17cxl/pci: Handle excessive CDAT lengthdrivers/cxl/core/pci.c+3 -00 replies
5/17PCI/DOE: Silence WARN splat with CONFIG_DEBUG_OBJECTS=ydrivers/pci/doe.c+3 -13 replies
6/17PCI/DOE: Fix memory leak with CONFIG_DEBUG_OBJECTS=ydrivers/pci/doe.c+1 -00 replies
7/17PCI/DOE: Provide synchronous API and use it internallydrivers/pci/doe.c include/linux/pci-doe.h+59 -160 replies
8/17cxl/pci: Use synchronous API for DOEdrivers/cxl/core/pci.c+22 -440 replies
9/17PCI/DOE: Make asynchronous API privatedrivers/pci/doe.c include/linux/pci-doe.h+43 -500 replies
10/17PCI/DOE: Deduplicate mailbox flushingdrivers/pci/doe.c+3 -60 replies
11/17PCI/DOE: Allow mailbox creation without devres managementdrivers/pci/doe.c+66 -370 replies
12/17PCI/DOE: Create mailboxes on device enumerationdrivers/pci/doe.c drivers/pci/pci.h drivers/pci/probe.c +3 more+91 -00 replies
13/17cxl/pci: Use CDAT DOE mailbox created by PCI coredrivers/cxl/core/pci.c drivers/cxl/cxlmem.h drivers/cxl/pci.c+5 -7411 replies
14/17PCI/DOE: Make mailbox creation API private.clang-format drivers/pci/doe.c include/linux/pci-doe.h+4 -520 replies
15/17PCI/DOE: Relax restrictions on request and response sizedrivers/pci/doe.c+49 -250 replies
16/17cxl/pci: Simplify CDAT retrieval error pathdrivers/cxl/core/pci.c+12 -111 reply
17/17cxl/pci: Rightsize CDAT response allocationdrivers/cxl/core/pci.c+19 -170 replies

Reviews trailers per patch

All 17 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchIra WeinyDan WilliamsMing LiJonathan CameronGregory PriceDavidlohr BuesoKuppuswamy SathyanarayananBjorn HelgaasLukas Wunner
SeriesA-b
1/17T-b R-b R-b
2/17T-b R-b R-b R-b R-b
3/17T-b R-b R-b
4/17T-b R-b R-b
5/17T-b R-b R-b R-b R-b T-b R-b
6/17T-b R-b R-b R-b R-b
7/17T-b R-b R-b R-b R-b R-b
8/17T-b R-b R-b
9/17T-b R-b R-b R-b
10/17T-b R-b R-b
11/17T-b R-b R-b
12/17T-b R-b R-b R-b
13/17T-b R-b R-b R-b R-b
14/17T-b R-b R-b R-b
15/17T-b R-b R-b
16/17R-b R-b
17/17T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 9 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/17] Collection of DOE material

Collection of DOE material, v4:

Migrate to synchronous API, create mailboxes in PCI core instead of in drivers, relax restrictions on request/response size.

This should probably go in via the cxl tree because Dave Jiang is basing his cxl work for the next merge window on it.

The first 6 patches are fixes, so could be applied immediately.

Thanks!

Changes v3 -> v4:

* [PATCH v4 01/17] cxl/pci: Fix CDAT retrieval on big endian
* In pci_doe_discovery(), add request_pl_le / response_pl_le variables to avoid typecasts in pci_doe_task initializer (Jonathan)
* In cxl_cdat_read_table(), use __le32 instead of u32 for "*data" variable (Jonathan)
* Use sizeof(__le32) instead of sizeof(u32) (Jonathan)

* [PATCH v4 03/17] cxl/pci: Handle truncated CDAT entries
* Check for sizeof(*entry) instead of sizeof(struct cdat_entry_header) for clarity (Jonathan)

* [PATCH v4 12/17] PCI/DOE: Create mailboxes on device enumeration
* Amend commit message with additional justification for the commit (Alexey)

* [PATCH v4 16/17] cxl/pci: cxl/pci: Simplify CDAT retrieval error path
* Newly added patch in v4 on popular request (Jonathan, Dave)

* [PATCH v4 17/17] cxl/pci: Rightsize CDAT response allocation
* Amend commit message with spec reference to the Table Access Response Header (Ira)
* In cxl_cdat_get_length(), check for sizeof(response) instead of 2 * sizeof(u32) for clarity

Link to v3:

https://lore.kernel.org/linux-pci/[email protected]/

Dave Jiang (1):
cxl/pci: Simplify CDAT retrieval error path

Lukas Wunner (16):
cxl/pci: Fix CDAT retrieval on big endian cxl/pci: Handle truncated CDAT header
cxl/pci: Handle truncated CDAT entries
cxl/pci: Handle excessive CDAT length
PCI/DOE: Silence WARN splat with CONFIG_DEBUG_OBJECTS=y PCI/DOE: Fix memory leak with CONFIG_DEBUG_OBJECTS=y PCI/DOE: Provide synchronous API and use it internally cxl/pci: Use synchronous API for DOE
PCI/DOE: Make asynchronous API private
PCI/DOE: Deduplicate mailbox flushing
PCI/DOE: Allow mailbox creation without devres management PCI/DOE: Create mailboxes on device enumeration cxl/pci: Use CDAT DOE mailbox created by PCI core PCI/DOE: Make mailbox creation API private PCI/DOE: Relax restrictions on request and response size cxl/pci: Rightsize CDAT response allocation

 .clang-format           |   1 -
 drivers/cxl/core/pci.c  | 140 +++++++---------
 drivers/cxl/cxlmem.h    |   3 -
 drivers/cxl/cxlpci.h    |  14 ++
 drivers/cxl/pci.c       |  49 ------
 drivers/pci/doe.c       | 342 ++++++++++++++++++++++++++++++----------
 drivers/pci/pci.h       |  11 ++
 drivers/pci/probe.c     |   1 +
 drivers/pci/remove.c    |   1 +
 include/linux/pci-doe.h |  62 +-------
 include/linux/pci.h     |   3 +
 11 files changed, 350 insertions(+), 277 deletions(-)
Signature · 1 line
2.39.1