can: rcar_canfd: Add support for R-Car V4H systems
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest12 patches 15 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | dt-bindings: can: renesas,rcar-canfd: R-Car V3U is R-Car Gen4Documentation/ | +7 | 1 reply | |
| 2/12 | dt-bindings: can: renesas,rcar-canfd: Document R-Car V4H supportDocumentation/ | +1 | 1 reply | |
| 3/12 | dt-bindings: can: renesas,rcar-canfd: Add transceiver supportDocumentation/ | +4 | 1 reply | |
| 4/12 | can: rcar_canfd: Fix R-Car V3U CAN mode selectiondrivers/ | +10 | 0 replies | |
| 5/12 | can: rcar_canfd: Fix R-Car V3U GAFLCFG field accessesdrivers/ | +2 | 0 replies | |
| 6/12 | can: rcar_canfd: Abstract out DCFG address differencesdrivers/ | +2 | 0 replies | |
| 7/12 | can: rcar_canfd: Add support for R-Car Gen4drivers/ | +50 | 0 replies | |
| 8/12 | can: rcar_canfd: Fix R-Car Gen4 DCFG.DSJW field widthdrivers/ | +2 | 0 replies | |
| 9/12 | can: rcar_canfd: Fix R-Car Gen4 CFCC.CFTML field widthdrivers/ | +2 | 0 replies | |
| 10/12 | can: rcar_canfd: Sort included header filesdrivers/ | +11 | 0 replies | |
| 11/12 | can: rcar_canfd: Add helper variable devdrivers/ | +42 | 0 replies | |
| 12/12 | can: rcar_canfd: Add transceiver supportdrivers/ | +25 | 6 replies |
Reviews trailers per patch
3 of 12 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Simon Horman | Rob Herring |
|---|---|---|
| Series | R-b | A-b A-b A-b |
| 1/12 | A-b | |
| 2/12 | A-b | |
| 3/12 | A-b | |
| 4/12 | ||
| 5/12 | ||
| 6/12 | ||
| 7/12 | ||
| 8/12 | ||
| 9/12 | ||
| 10/12 | ||
| 11/12 | ||
| 12/12 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/12] can: rcar_canfd: Add support for R-Car V4H systems
Hi all,
This patch series adds support for the CAN-FD interface on the Renesas R-Car V4H (R8A779G0) SoC and support for CAN transceivers described as PHYs to the R-Car CAN-FD driver. It includes several fixes for issues (some minor) detected while adding the support and during testing. More details can be found in the individual patches.
Note that the last patch depends on "[PATCH 1/7] phy: Add devm_of_phy_optional_get() helper"[1].
This has been tested on the Renesas White-Hawk development board using cansend, candump, and canfdtest:
- Channel 0 uses an NXP TJR1443AT CAN transceiver, and works fine,
- Channels 1-7 use Microchip MCP2558FD-H/SN CAN transceivers (not mounted for channels 4-7), which do not need explicit description. While channel 1 works fine, channels 2-3 do not seem to work.
Hence despite the new fixes, the test results are similar to what Ulrich Hecht reported for R-Car V3U on the Falcon development board before, i.e. only channels 0 and 1 work (FTR, [2] does not help). Whether this is a CAN-FD driver issue, a pin control issue, an IP core issue, or an SoC integration issue is still to be seen...
Thanks for your comments!
[1] https://lore.kernel.org/all/f53a1bcca637ceeafb04ce3540a605532d3bc34a.1674036164.git.geert+renesas@glider.be
[2] commit e3e5bccc92446048 ("can: rcar_canfd:
rcar_canfd_configure_afl_rules(): Fix Rx FIFO entry setting") in renesas-bsp/v5.10.147/rcar-5.2.0.rc3.
Geert Uytterhoeven (12):
dt-bindings: can: renesas,rcar-canfd: R-Car V3U is R-Car Gen4
dt-bindings: can: renesas,rcar-canfd: Document R-Car V4H support
dt-bindings: can: renesas,rcar-canfd: Add transceiver support
can: rcar_canfd: Fix R-Car V3U CAN mode selection
can: rcar_canfd: Fix R-Car V3U GAFLCFG field accesses
can: rcar_canfd: Abstract out DCFG address differences
can: rcar_canfd: Add support for R-Car Gen4
can: rcar_canfd: Fix R-Car Gen4 DCFG.DSJW field width
can: rcar_canfd: Fix R-Car Gen4 CFCC.CFTML field width
can: rcar_canfd: Sort included header files
can: rcar_canfd: Add helper variable dev
can: rcar_canfd: Add transceiver support
.../bindings/net/can/renesas,rcar-canfd.yaml | 16 +- drivers/net/can/rcar/rcar_canfd.c | 255 ++++++++++-------- 2 files changed, 148 insertions(+), 123 deletions(-)
Signature · 12 lines
2.34.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds