Skip to content

Convert drivers to return XFRM configuration errors through extack

Leon Romanovsky intel-wired-lan linux-doc lkml netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 7 repliesApplied 10/10

Changes in v1 from the cover letter

* Fixed rebase errors in mlx5 and cxgb4 drivers
* Fixed previously existed typo in nfp driver
* Added Simon's ROB
* Removed my double SOB tags
v0: https://lore.kernel.org/all/[email protected]

Patches in v1 All 10 applied

#Subject and filesSizeRepliesApplied
1/10xfrm: extend add policy callback to set failure reasonDocumentation/networking/xfrm_device.rst drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c include/linux/netdevice.h +1 more+5 -55 repliesApplied
2/10net/mlx5e: Fill IPsec policy validation failure reasondrivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c+12 -100 repliesApplied
3/10xfrm: extend add state callback to set failure reasonDocumentation/networking/xfrm_device.rst drivers/net/bonding/bond_main.c drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +9 more+30 -200 repliesApplied
4/10net/mlx5e: Fill IPsec state validation failure reasondrivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c+32 -430 repliesApplied
5/10netdevsim: Fill IPsec state validation failure reasondrivers/net/netdevsim/ipsec.c+5 -60 repliesApplied
6/10nfp: fill IPsec state validation failure reasondrivers/net/ethernet/netronome/nfp/crypto/ipsec.c+19 -190 repliesApplied
7/10ixgbevf: fill IPsec state validation failure reasondrivers/net/ethernet/intel/ixgbevf/ipsec.c+8 -90 repliesApplied
8/10ixgbe: fill IPsec state validation failure reasondrivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c+10 -110 repliesApplied
9/10bonding: fill IPsec state validation failure reasondrivers/net/bonding/bond_main.c+1 -10 repliesApplied
10/10cxgb4: fill IPsec state validation failure reasondrivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c+15 -160 repliesApplied

Reviews trailers per patch

1 of 10 patches has a Reviewed-by or Acked-by.

PatchSimon Horman
1/10
2/10
3/10
4/10
5/10
6/10R-b
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next v1 00/10] Convert drivers to return XFRM configuration errors through extack

Changelog
v1:
* Fixed rebase errors in mlx5 and cxgb4 drivers
* Fixed previously existed typo in nfp driver
* Added Simon's ROB
* Removed my double SOB tags
v0: https://lore.kernel.org/all/[email protected]

---------------------------------------------------------------------------

Hi,

This series continues effort started by Sabrina to return XFRM configuration errors through extack. It allows for user space software stack easily present driver failure reasons to users.

As a note, Intel drivers have a path where extack is equal to NULL, and error prints won't be available in current patchset. If it is needed, it can be changed by adding special to Intel macro to print to dmesg in case of extack == NULL.

Thanks

Leon Romanovsky (10):
xfrm: extend add policy callback to set failure reason net/mlx5e: Fill IPsec policy validation failure reason
xfrm: extend add state callback to set failure reason net/mlx5e: Fill IPsec state validation failure reason
netdevsim: Fill IPsec state validation failure reason
nfp: fill IPsec state validation failure reason
ixgbevf: fill IPsec state validation failure reason
ixgbe: fill IPsec state validation failure reason
bonding: fill IPsec state validation failure reason
cxgb4: fill IPsec state validation failure reason

 Documentation/networking/xfrm_device.rst      |   4 +-
 drivers/net/bonding/bond_main.c               |  10 +-
 .../net/ethernet/chelsio/cxgb4/cxgb4_main.c   |   8 +-
 .../inline_crypto/ch_ipsec/chcr_ipsec.c       |  34 +++---
 .../net/ethernet/intel/ixgbe/ixgbe_ipsec.c    |  27 ++---
 drivers/net/ethernet/intel/ixgbevf/ipsec.c    |  21 ++--
 .../mellanox/mlx5/core/en_accel/ipsec.c       | 103 ++++++++----------
 .../net/ethernet/netronome/nfp/crypto/ipsec.c |  41 +++----
 drivers/net/netdevsim/ipsec.c                 |  14 +--
 include/linux/netdevice.h                     |   4 +-
 net/xfrm/xfrm_device.c                        |   9 +-
 net/xfrm/xfrm_state.c                         |   2 +-
 12 files changed, 137 insertions(+), 140 deletions(-)
Signature · 6 lines
2.39.1

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Read the cover letter in its thread