Skip to content

lib/stackdepot: fixes and clean-ups

[email protected] linux-mm lkml 2 versions – Applied

Status from this message: [merged mm-stable] lib-stackdepot-various-comments-clean-ups.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest18 patches 13 repliesApplied 18/18
  2. v118 patches 32 repliesSuperseded

Changes in v2 from the cover letter

- Drop "lib/stackdepot: fix setting next_slab_inited in init_stack_slab", as there is no bug to fix.
- Use "pool" instead of "slab" for memory regions that store stack traces.
- Rename next_slab/pool_inited to next_slab/pool_required and annotate its uses with comments, see new patch #13.
- Use STACK_HASH_TABLE_SCALE as a new name for STACK_HASH_SCALE.
- Mark stack_depot_set_extra_bits as __must_check.
- Only assign extra bits in stack_depot_set_extra_bits for non-empty handles.
- Minor comment fixes.

Patches in v2 All 18 applied

#Subject and filesSizeRepliesApplied
1/18lib/stackdepot: put functions in logical orderinclude/linux/stackdepot.h lib/stackdepot.c+165 -1640 repliesApplied
2/18lib/stackdepot: use pr_fmt to define message formatlib/stackdepot.c+6 -40 repliesApplied
3/18lib/stackdepot, mm: rename stack_depot_want_early_initinclude/linux/stackdepot.h lib/stackdepot.c mm/page_owner.c +1 more+15 -150 repliesApplied
4/18lib/stackdepot: rename stack_depot_disablelib/stackdepot.c+10 -100 repliesApplied
5/18lib/stackdepot: annotate init and early init functionslib/stackdepot.c+21 -60 repliesApplied
6/18lib/stackdepot: lower the indentation in stack_depot_initlib/stackdepot.c+37 -330 repliesApplied
7/18lib/stackdepot: reorder and annotate global variableslib/stackdepot.c+17 -101 replyApplied
8/18lib/stackdepot: rename hash table constants and variableslib/stackdepot.c+21 -211 replyApplied
9/18lib/stackdepot: rename slab to poollib/stackdepot.c+53 -532 repliesApplied
10/18lib/stackdepot: rename handle and pool constantslib/stackdepot.c+27 -290 repliesApplied
11/18lib/stackdepot: rename init_stack_poollib/stackdepot.c+5 -50 repliesApplied
12/18lib/stacktrace: drop impossible WARN_ON for depot_init_poollib/stackdepot.c+5 -71 replyApplied
13/18lib/stackdepot: annotate depot_init_pool and depot_alloc_stacklib/stackdepot.c+24 -101 replyApplied
14/18lib/stackdepot: rename next_pool_inited to next_pool_requiredlib/stackdepot.c+21 -91 replyApplied
15/18lib/stacktrace, kasan, kmsan: rework extra_bits interfaceinclude/linux/stackdepot.h lib/stackdepot.c mm/kasan/common.c +1 more+44 -141 replyApplied
16/18lib/stackdepot: annotate racy pool_index accesseslib/stackdepot.c+12 -31 replyApplied
17/18lib/stackdepot: various comments clean-upsinclude/linux/stackdepot.h lib/stackdepot.c+78 -782 repliesApplied
18/18lib/stackdepot: move documentation comments to stackdepot.hinclude/linux/stackdepot.h lib/stackdepot.c+87 -872 repliesApplied

Reviews trailers per patch

All 18 patches have a Reviewed-by or Acked-by.

PatchAlexander PotapenkoVlastimil Babka
1/18R-b
2/18R-b
3/18R-b A-b
4/18R-b
5/18R-b
6/18R-b
7/18R-b
8/18R-b
9/18R-b A-b
10/18R-b
11/18R-b
12/18R-b
13/18R-b
14/18R-b
15/18R-b
16/18R-b
17/18R-b
18/18R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/18] lib/stackdepot: fixes and clean-ups

From: Andrey Konovalov <[email protected]>

A set of fixes, comments, and clean-ups I came up with while reading the stack depot code.

Changes v1->v2:
- Drop "lib/stackdepot: fix setting next_slab_inited in init_stack_slab", as there is no bug to fix.
- Use "pool" instead of "slab" for memory regions that store stack traces.
- Rename next_slab/pool_inited to next_slab/pool_required and annotate its uses with comments, see new patch #13.
- Use STACK_HASH_TABLE_SCALE as a new name for STACK_HASH_SCALE.
- Mark stack_depot_set_extra_bits as __must_check.
- Only assign extra bits in stack_depot_set_extra_bits for non-empty handles.
- Minor comment fixes.

Andrey Konovalov (18):
lib/stackdepot: put functions in logical order lib/stackdepot: use pr_fmt to define message format lib/stackdepot, mm: rename stack_depot_want_early_init lib/stackdepot: rename stack_depot_disable lib/stackdepot: annotate init and early init functions lib/stackdepot: lower the indentation in stack_depot_init lib/stackdepot: reorder and annotate global variables lib/stackdepot: rename hash table constants and variables lib/stackdepot: rename slab to pool
lib/stackdepot: rename handle and pool constants lib/stackdepot: rename init_stack_pool lib/stacktrace: drop impossible WARN_ON for depot_init_pool lib/stackdepot: annotate depot_init_pool and depot_alloc_stack lib/stackdepot: rename next_pool_inited to next_pool_required lib/stacktrace, kasan, kmsan: rework extra_bits interface lib/stackdepot: annotate racy pool_index accesses lib/stackdepot: various comments clean-ups lib/stackdepot: move documentation comments to stackdepot.h

 include/linux/stackdepot.h | 152 +++++++--
 lib/stackdepot.c           | 654 ++++++++++++++++++-------------------
 mm/kasan/common.c          |   2 +-
 mm/kmsan/core.c            |  10 +-
 mm/page_owner.c            |   2 +-
 mm/slub.c                  |   4 +-
 6 files changed, 457 insertions(+), 367 deletions(-)
Signature · 1 line
2.25.1