Skip to content

crypto: x86/twofish-3way - Cleanup and optimize asm

Peter Lafreniere linux-crypto 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3crypto: x86/twofish-3way - Remove unused encode parameterarch/x86/crypto/twofish-x86_64-asm_64-3way.S arch/x86/crypto/twofish.h arch/x86/crypto/twofish_avx_glue.c +1 more+4 -290 replies
2/3crypto: x86/twofish-3way - Perform cbc xor in assemblyarch/x86/crypto/twofish-x86_64-asm_64-3way.S arch/x86/crypto/twofish.h arch/x86/crypto/twofish_glue_3way.c+45 -190 replies
3/3crypto: x86/twofish-3way - Remove unused macro argumentarch/x86/crypto/twofish-x86_64-asm_64-3way.S+12 -120 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] crypto: x86/twofish-3way - Cleanup and optimize asm

1/3 removes the unused xor argument to encode functions. This argument is deadweight and its removal shaves off a both a few cycles per call as well as a small amount of lines.

2/3 moves handling for cbc mode decryption to assembly in order to remove overhead, yielding a ~6% speedup on AMD Zen1.

3/3 makes a minor readability change that doesn't fit well into 2/3.

Peter Lafreniere (3):
crypto: x86/twofish-3way - Remove unused encode parameter
crypto: x86/twofish-3way - Perform cbc xor in assembly
crypto: x86/twofish-3way - Remove unused macro argument

 arch/x86/crypto/twofish-x86_64-asm_64-3way.S | 71 ++++++++++++--------
 arch/x86/crypto/twofish.h                    | 19 ++++--
 arch/x86/crypto/twofish_avx_glue.c           |  5 --
 arch/x86/crypto/twofish_glue_3way.c          | 22 +-----
 4 files changed, 59 insertions(+), 58 deletions(-)
Signature · 1 line
2.39.1