Skip to content

staging: vt6655: Macro with braces issue changed to inline function

Guru Mehar Rachaputi linux-staging lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest0 of 4 patches 4 repliesIn review

Changes in v2 from the cover letter

- Macros with one statement that is to call 'iowrite8' function changed to inline function as reviewed by [email protected]. In relation to this, names of the callers of macro are also modified to call this function.

Patches in v2 No applies recorded yet

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/4] staging: vt6655: Macro with braces issue changed to inline function

This patch is to fix checkpatch warning: "Macro argument 'iobase' may be better as '(iobase)' to avoid precedence issues" changed to inline function. In relation to this, names of the callers of macro are also modified to call this function.

Changes in v4:
- Modified commit message to be clear

Changes in v3:
1. Whitespace error from checkpatch fixed
2. Should be applied together with changes in v2 for testing

Changes in v2:
- Macros with one statement that is to call 'iowrite8' function changed to inline function as reviewed by [email protected]. In relation to this, names of the callers of macro are also modified to call this function.

Guru Mehar Rachaputi (4):
staging: vt6655: Add braces to macro parameter 'iobase'
staging: vt6655: Macro with braces issue change to inline function
staging: vt6655: Macro with braces issue change to inline function
staging: vt6655: Macro with braces issue changed to inline function

 drivers/staging/vt6655/card.c        |  4 ++--
 drivers/staging/vt6655/channel.c     |  4 ++--
 drivers/staging/vt6655/device_main.c | 12 ++++++------
 drivers/staging/vt6655/mac.c         |  8 ++++----
 drivers/staging/vt6655/mac.h         | 12 +++++++++---
 5 files changed, 23 insertions(+), 17 deletions(-)
Signature · 6 lines
2.34.1


-- 
Thanks & Regards,
Guru