Skip to content

Extend and rename intel_tiling_info library

Karolina Stolarek igt-dev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest9 patches 8 repliesIn review
  2. v26 patches 4 repliesSuperseded

Changes in v3 from the cover letter

- Rename blt_cmds_desc struct to intel_cmds_info
- Update ifdef in intel_cmds_info header (it still said TILING)
- Move blt_get_cmd_info() helper from i915_blt to the library, make it public
- Change supported_cmds field name to blt_cmds, as it only refers to the blitter copy commands
- Correct MTL definition
- Smaller renames, such as GET_BLT_INFO --> GET_CMDS_INFO

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9lib/intel_tiling_info: Rename blt_cmd_info to intel_cmds_infolib/i915/i915_blt.c lib/i915/i915_blt.h lib/i915/intel_tiling_info.c +3 more+68 -681 reply
2/9lib/intel_tiling_info: Update names of commands definitionslib/i915/intel_tiling_info.c lib/i915/intel_tiling_info.h lib/intel_device_info.c+41 -411 reply
3/9lib/intel_tiling_info: Update intel_cmds_info field namelib/i915/i915_blt.c lib/i915/intel_tiling_info.c lib/i915/intel_tiling_info.h+9 -91 reply
4/9lib/intel_device_info: Update name for cmds_info getterlib/i915/i915_blt.c lib/intel_chipset.h lib/intel_device_info.c+8 -81 reply
5/9lib/intel_tiling_info: Rename blt_tiling_info to blt_cmd_infolib/i915/i915_blt.c lib/i915/intel_tiling_info.c lib/i915/intel_tiling_info.h+14 -140 replies
6/9lib/i915: Rename intel_tiling_info librarylib/i915/i915_blt.h lib/i915/intel_cmds_info.c lib/i915/intel_cmds_info.h +2 more+8 -81 reply
7/9lib/intel_cmds_info: Add flags field to describe command propertieslib/i915/intel_cmds_info.c lib/i915/intel_cmds_info.h+26 -61 reply
8/9lib/i915_blt: Add checks for command propertieslib/i915/i915_blt.c lib/i915/i915_blt.h lib/i915/intel_cmds_info.c +1 more+84 -21 reply
9/9tests/gem_ccs: Check for extended block-copy and compression supportlib/i915/i915_blt.c lib/i915/i915_blt.h tests/i915/gem_ccs.c+3 -221 reply

Reviews trailers per patch

5 of 9 patches have a Reviewed-by or Acked-by.

PatchZbigniew Kempczyński
1/9R-b
2/9
3/9
4/9
5/9
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [igt-dev] [PATCH i-g-t v3 0/9] Extend and rename intel_tiling_info library

As for now, there is no central place that provides information on command properties such as compression support or if the command requires any additional setup. It is possible to modify the already existing library, intel_tiling_info, and add such information there.

The series adds a new field to better describe blitter commands, which stores bit flags describing properties. Flags defined as a part of the series mostly target the block-copy command, as its features vary the most between generations. The introduction of the field is followed by an update of DG2 and MTL definitions and gem_ccs test.

It was decided that the former blt_cmd_info struct will not only host information on command properties, but will also describe non-blitter copy commands. Because of this, in v3 we rename related structs, functions and variables. To make reviewing easier, the additional rename was split into three commits: intel_cmds_info definitions update, supported_cmds field rename and intel_cmds_info getter rename.

The most important name updates are:
- intel_tiling_info lib ---> intel_cmds_info lib
- blt_cmd_info struct ---> intel_cmds_info struct
- blt_tiling_info struct ---> blt_cmd_info struct

v3:
- Rename blt_cmds_desc struct to intel_cmds_info
- Update ifdef in intel_cmds_info header (it still said TILING)
- Move blt_get_cmd_info() helper from i915_blt to the library, make it public
- Change supported_cmds field name to blt_cmds, as it only refers to the blitter copy commands
- Correct MTL definition
- Smaller renames, such as GET_BLT_INFO --> GET_CMDS_INFO

v2:
- Rename the library and its structs to better describe what they store
- Stop using has_flatccs field when checking if a command can use compression; use blt_cmd_info flags field instead
- Update the name of blt_tiling field in intel_device_info, as it describes more than just a list of supported tiling formats
- Drop additional macros for DG2 and MTL definitions

Karolina Stolarek (9):
lib/intel_tiling_info: Rename blt_cmd_info to intel_cmds_info lib/intel_tiling_info: Update names of commands definitions lib/intel_tiling_info: Update intel_cmds_info field name lib/intel_device_info: Update name for cmds_info getter lib/intel_tiling_info: Rename blt_tiling_info to blt_cmd_info lib/i915: Rename intel_tiling_info library lib/intel_cmds_info: Add flags field to describe command properties lib/i915_blt: Add checks for command properties tests/gem_ccs: Check for extended block-copy and compression support

 lib/i915/i915_blt.c          | 121 +++++++++++++++++++++++-----------
 lib/i915/i915_blt.h          |  15 +++--
 lib/i915/intel_cmds_info.c   | 122 +++++++++++++++++++++++++++++++++++
 lib/i915/intel_cmds_info.h   |  55 ++++++++++++++++
 lib/i915/intel_tiling_info.c |  95 ---------------------------
 lib/i915/intel_tiling_info.h |  48 --------------
 lib/intel_chipset.h          |   6 +-
 lib/intel_device_info.c      |  68 +++++++++----------
 lib/meson.build              |   6 +-
 tests/i915/gem_ccs.c         |   7 +-
 10 files changed, 313 insertions(+), 230 deletions(-)
 create mode 100644 lib/i915/intel_cmds_info.c
 create mode 100644 lib/i915/intel_cmds_info.h
 delete mode 100644 lib/i915/intel_tiling_info.c
 delete mode 100644 lib/i915/intel_tiling_info.h
Signature · 1 line
2.25.1