Skip to content

RFC Make iscsid-kernel communications namespace-aware

Lee Duncan linux-scsi netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest9 patches 20 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9iscsi: create per-net iscsi netlink kernel socketsdrivers/scsi/scsi_transport_iscsi.c+63 -101 reply
2/9iscsi: associate endpoints with a hostdrivers/infiniband/ulp/iser/iscsi_iser.c drivers/scsi/be2iscsi/be_iscsi.c drivers/scsi/bnx2i/bnx2i_iscsi.c +5 more+13 -88 replies
3/9iscsi: sysfs filtering by network namespacedrivers/scsi/scsi_transport_iscsi.c include/scsi/scsi_transport_iscsi.h+110 -151 reply
4/9iscsi: make all iSCSI netlink multicast namespace awaredrivers/scsi/scsi_transport_iscsi.c+60 -329 replies
5/9iscsi: set netns for iscsi_tcp hostsdrivers/scsi/iscsi_tcp.c drivers/scsi/scsi_transport_iscsi.c include/scsi/scsi_transport_iscsi.h+14 -14 replies
6/9iscsi: check net namespace for all iscsi lookupdrivers/infiniband/ulp/iser/iscsi_iser.c drivers/scsi/be2iscsi/be_iscsi.c drivers/scsi/bnx2i/bnx2i_iscsi.c +5 more+149 -871 reply
7/9iscsi: convert flashnode devices from bus to classdrivers/scsi/qla4xxx/ql4_os.c drivers/scsi/scsi_transport_iscsi.c include/scsi/scsi_transport_iscsi.h+18 -221 reply
8/9iscsi: rename iscsi_bus_flash_* to iscsi_flash_*drivers/scsi/qla4xxx/ql4_os.c drivers/scsi/scsi_transport_iscsi.c include/scsi/scsi_transport_iscsi.h+102 -1001 reply
9/9iscsi: filter flashnode sysfs by net namespacedrivers/scsi/scsi_transport_iscsi.c include/scsi/scsi_transport_iscsi.h+34 -41 reply

Reviews trailers per patch

7 of 9 patches have a Reviewed-by or Acked-by.

PatchHannes Reinecke
1/9R-b
2/9
3/9R-b
4/9R-b R-b R-b
5/9
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC 0/9] Make iscsid-kernel communications namespace-aware

From: Lee Duncan <[email protected]>

This is a request for comment on a set of patches that modify the kernel iSCSI initiator communications so that they are namespace-aware. The goal is to allow multiple iSCSI daemon (iscsid) to run at once as long as they are in separate namespaces, and so that iscsid can run in containers.

Comments and suggestions are more than welcome. I do not expect that this code is production-ready yet, and networking isn't my strongest suit (yet).

These patches were originally posted in 2015 by Chris Leech. There were some issues at the time about how to handle namespaces going away. I hope to address any issues raised with this patchset and then to merge these changes upstream to address working in working in containers.

My contribution thus far has been to update these patches to work with the current upstream kernel.

Chris Leech/Lee Duncan (9):
iscsi: create per-net iscsi netlink kernel sockets
iscsi: associate endpoints with a host
iscsi: sysfs filtering by network namespace
iscsi: make all iSCSI netlink multicast namespace aware
iscsi: set netns for iscsi_tcp hosts
iscsi: check net namespace for all iscsi lookup
iscsi: convert flashnode devices from bus to class
iscsi: rename iscsi_bus_flash_* to iscsi_flash_*
iscsi: filter flashnode sysfs by net namespace

 drivers/infiniband/ulp/iser/iscsi_iser.c |   7 +-
 drivers/scsi/be2iscsi/be_iscsi.c         |   6 +-
 drivers/scsi/bnx2i/bnx2i_iscsi.c         |   6 +-
 drivers/scsi/cxgbi/libcxgbi.c            |   6 +-
 drivers/scsi/iscsi_tcp.c                 |   7 +
 drivers/scsi/qedi/qedi_iscsi.c           |   6 +-
 drivers/scsi/qla4xxx/ql4_os.c            |  64 +--
 drivers/scsi/scsi_transport_iscsi.c      | 625 ++++++++++++++++-------
 include/scsi/scsi_transport_iscsi.h      |  63 ++-
 9 files changed, 537 insertions(+), 253 deletions(-)
Signature · 1 line
2.39.1