Skip to content

staging: rtl8192e: Remove entries from struct rtl819x_ops start with .tx_enable

Philipp Hortmann linux-staging lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7staging: rtl8192e: Remove entry .tx_enable from struct rtl819x_opsdrivers/staging/rtl8192e/rtl8192e/rtl_core.c drivers/staging/rtl8192e/rtl8192e/rtl_core.h+1 -30 replies
2/7staging: rtl8192e: Remove entry .interrupt_re.. from struct rtl819x_opsdrivers/staging/rtl8192e/rtl8192e/rtl_core.c drivers/staging/rtl8192e/rtl8192e/rtl_core.h+1 -40 replies
3/7staging: rtl8192e: Remove entry .tx_check_stuc.. from struct rtl819x_opsdrivers/staging/rtl8192e/rtl8192e/rtl_core.c drivers/staging/rtl8192e/rtl8192e/rtl_core.h+1 -30 replies
4/7staging: rtl8192e: Remove entry .rx_check_stuc.. from struct rtl819x_opsdrivers/staging/rtl8192e/rtl8192e/rtl_core.c drivers/staging/rtl8192e/rtl8192e/rtl_core.h+1 -50 replies
5/7staging: rtl8192e: Remove dead code from struct rtl819x_opsdrivers/staging/rtl8192e/rtl8192e/rtl_core.c drivers/staging/rtl8192e/rtl8192e/rtl_core.h+0 -70 replies
6/7staging: rtl8192e: Remove entry .link_change from struct rtl819x_opsdrivers/staging/rtl8192e/rtl8192e/rtl_core.c drivers/staging/rtl8192e/rtl8192e/rtl_core.h+1 -30 replies
7/7staging: rtl8192e: Remove entry .nic_type from struct rtl819x_opsdrivers/staging/rtl8192e/rtl8192e/rtl_core.c drivers/staging/rtl8192e/rtl8192e/rtl_core.h drivers/staging/rtl8192e/rtl8192e/rtl_pci.c+3 -51 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] staging: rtl8192e: Remove entries from struct rtl819x_ops start with .tx_enable

Remove unnecessary entries from rtl819x_ops and replace them with function names when required. This increases readability of the code as the reader does not always need to look up the corresponding function name. One patch just removes dead code which increases also readability.

Tested with rtl8192e
Transferred this patch over wlan connection of rtl8192e

This patch series requires the this patch series:
"[PATCH 00/11] staging: rtl8192e: Remove entries from struct rtl819x_ops start with .get_eeprom_size"

Philipp Hortmann (7):
staging: rtl8192e: Remove entry .tx_enable from struct rtl819x_ops
staging: rtl8192e: Remove entry .interrupt_re.. from struct

    rtl819x_ops
  staging: rtl8192e: Remove entry .tx_check_stuc.. from struct
    rtl819x_ops
  staging: rtl8192e: Remove entry .rx_check_stuc.. from struct
    rtl819x_ops

staging: rtl8192e: Remove dead code from struct rtl819x_ops
staging: rtl8192e: Remove entry .link_change from struct rtl819x_ops
staging: rtl8192e: Remove entry .nic_type from struct rtl819x_ops

 drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 20 +++++---------------
 drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 12 ------------
 drivers/staging/rtl8192e/rtl8192e/rtl_pci.c  |  6 +++---
 3 files changed, 8 insertions(+), 30 deletions(-)
Signature · 1 line
2.39.2