Skip to content

Add RT5033 charger device driver

Jakob Hauser linux-devicetree linux-pm lkml phone-devel 7 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest posting 2/210 patches 16 repliesApplied
  2. v6 posting 1/210 patches 0 repliesSuperseded
  3. v510 patches 9 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v48 patches12 repliesSuperseded
v38 patches11 repliesSuperseded
v29 patches17 repliesSuperseded
v110 patches19 repliesApplied

Changes in v6 from the cover letter

- Patch 5: In function rt5033_charger_probe() after
calling rt5033_charger_dt_init() replaced the return value from "-ENODEV" to "PTR_ERR(charger->chg)", as suggested by Christophe.
- Patch 9: Changed the patch from adding "power-supplies: true" to replacing "additionalProperties: false" by "unevaluatedProperties: false", as suggested by Krzysztof.

Patches in v6 posting 2/2 Applied

#Subject and filesSizeRepliesApplied
1/10mfd: rt5033: Drop rt5033-battery sub-devicedrivers/mfd/rt5033.c+0 -30 replies
2/10mfd: rt5033: Fix chip revision readoutdrivers/mfd/rt5033.c include/linux/mfd/rt5033-private.h+7 -20 replies
3/10mfd: rt5033: Fix STAT_MASK, HZ_MASK and AICR definesinclude/linux/mfd/rt5033-private.h+5 -40 replies
4/10mfd: rt5033: Apply preparatory changes before adding rt5033-charger driverinclude/linux/mfd/rt5033-private.h include/linux/mfd/rt5033.h+36 -192 replies
5/10power: supply: rt5033_charger: Add RT5033 charger device driverdrivers/power/supply/Kconfig drivers/power/supply/Makefile drivers/power/supply/rt5033_charger.c +1 more+481 -160 replies
6/10power: supply: rt5033_charger: Add cable detection and USB OTG supplydrivers/power/supply/rt5033_charger.c+274 -26 replies
7/10power: supply: rt5033_battery: Move struct rt5033_battery to battery driverdrivers/power/supply/rt5033_battery.c include/linux/mfd/rt5033.h+8 -90 replies
8/10power: supply: rt5033_battery: Adopt status property from chargerdrivers/power/supply/rt5033_battery.c+23 -60 replies
9/10dt-bindings: power: supply: rt5033-battery: Apply unevaluatedPropertiesDocumentation/devicetree/bindings/power/supply/richtek,rt5033-battery.yaml+1 -12 replies
10/10dt-bindings: Add rt5033 mfd, regulator and chargerDocumentation/devicetree/bindings/mfd/richtek,rt5033.yaml Documentation/devicetree/bindings/power/supply/richtek,rt5033-charger.yaml+203 -00 replies

Reviews trailers per patch

7 of 10 patches have a Reviewed-by or Acked-by.

PatchLee JonesLinus WalleijRaymond HackleySebastian ReichelKrzysztof KozlowskiConor Dooley
1/10A-b R-b
2/10
3/10Acked-for-MFD-by
4/10
5/10R-b T-b A-b
6/10T-b A-b
7/10A-b
8/10A-b
9/10A-b A-b
10/10R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v6 thread

Cover letter [PATCH v6 00/10 RESEND] Add RT5033 charger device driver

This patchset adds the charger driver "rt5033-charger". It is part of the multifunction device rt5033. The patchset is based on an older version by Beomho Seo of March 2015. For more information on the history and setup of the patchset see the cover sheet of version v1, there is a link further down below the changelog.

RESEND: Sorry for spamming. The first try of sending v6 got interrupted and was split into two threads on the lore list. Therefore sending it again.

Changes in v6:
- Patch 5: In function rt5033_charger_probe() after
calling rt5033_charger_dt_init() replaced the return value from "-ENODEV" to "PTR_ERR(charger->chg)", as suggested by Christophe.
- Patch 9: Changed the patch from adding "power-supplies: true" to replacing "additionalProperties: false" by "unevaluatedProperties: false", as suggested by Krzysztof.

v1: https://lore.kernel.org/linux-pm/[email protected]/T/#t
v2: https://lore.kernel.org/linux-pm/[email protected]/T/#t
v3: https://lore.kernel.org/linux-pm/[email protected]/T/#t
v4: https://lore.kernel.org/linux-pm/[email protected]/T/#t
v5: https://lore.kernel.org/linux-pm/[email protected]/T/#t

The result of the patchset v6 can be seen at:
https://github.com/Jakko3/linux/blob/rt5033-charger_v6/drivers/power/supply/rt5033_charger.c

Jakob Hauser (9):
mfd: rt5033: Fix chip revision readout
mfd: rt5033: Fix STAT_MASK, HZ_MASK and AICR defines
mfd: rt5033: Apply preparatory changes before adding rt5033-charger
driver
power: supply: rt5033_charger: Add RT5033 charger device driver
power: supply: rt5033_charger: Add cable detection and USB OTG supply
power: supply: rt5033_battery: Move struct rt5033_battery to battery
driver
power: supply: rt5033_battery: Adopt status property from charger
dt-bindings: power: supply: rt5033-battery: Apply
unevaluatedProperties
dt-bindings: Add rt5033 mfd, regulator and charger

Stephan Gerhold (1):
mfd: rt5033: Drop rt5033-battery sub-device

 .../bindings/mfd/richtek,rt5033.yaml          | 138 ++++
 .../power/supply/richtek,rt5033-battery.yaml  |   2 +-
 .../power/supply/richtek,rt5033-charger.yaml  |  65 ++
 drivers/mfd/rt5033.c                          |   8 +-
 drivers/power/supply/Kconfig                  |   8 +
 drivers/power/supply/Makefile                 |   1 +
 drivers/power/supply/rt5033_battery.c         |  38 +-
 drivers/power/supply/rt5033_charger.c         | 744 ++++++++++++++++++
 include/linux/mfd/rt5033-private.h            |  64 +-
 include/linux/mfd/rt5033.h                    |  24 -
 10 files changed, 1034 insertions(+), 58 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mfd/richtek,rt5033.yaml
 create mode 100644 Documentation/devicetree/bindings/power/supply/richtek,rt5033-charger.yaml
 create mode 100644 drivers/power/supply/rt5033_charger.c
Signature · 1 line
2.39.2