Skip to content

staging: rtl8192e: Removing rf_type RF_2T4R from driver

Philipp Hortmann linux-staging lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2staging: rtl8192e: Remove empty Array Rtl8192PciEPHY_REGArraydrivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h drivers/staging/rtl8192e/rtl8192e/table.c +1 more+1 -102 replies
2/2staging: rtl8192e: Remove conditions for RF_2T4Rdrivers/staging/rtl8192e/rtl8192e/r8192E_dev.c drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +1 more+25 -1090 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] staging: rtl8192e: Removing rf_type RF_2T4R from driver

Removing rf_type RF_2T4R from driver as it is dead code.

First reason:
The following table is used to configure the phy base band:
u32 Rtl8192PciEPHY_REGArray[PHY_REGArrayLengthPciE] = {0x0,}; A valid array has at least two columns.

Second reason:
According to a list of devices from wiki the seven shown devices do only support MIMO config: 1x2:2 in phy modes b,g,n. The only rf chip that is used is RTL8256.

Tested with rtl8192e
Transferred this patch over wlan connection of rtl8192e

This patch series requires the patches:
"[PATCH] staging: rtl8192e: Change filename r8192E_hwimg.x to table.x" "[PATCH] staging: rtl8192e: Remove call_usermodehelper starting RadioPower.sh" "[PATCH] staging: rtl8192e: Remove function ..dm_check_ac_dc_power calling a script"

Philipp Hortmann (2):
staging: rtl8192e: Remove empty Array Rtl8192PciEPHY_REGArray
staging: rtl8192e: Remove conditions for RF_2T4R

 .../staging/rtl8192e/rtl8192e/r8192E_dev.c    |   3 +-
 .../staging/rtl8192e/rtl8192e/r8192E_phy.c    |  26 +----
 .../staging/rtl8192e/rtl8192e/r8192E_phy.h    |   2 -
 drivers/staging/rtl8192e/rtl8192e/rtl_dm.c    | 109 ++++--------------
 drivers/staging/rtl8192e/rtl8192e/table.c     |   2 -
 drivers/staging/rtl8192e/rtl8192e/table.h     |   2 -
 drivers/staging/rtl8192e/rtllib.h             |   1 -
 7 files changed, 26 insertions(+), 119 deletions(-)
Signature · 1 line
2.39.2