Skip to content

staging: rtl8192e: Removing unused arrays ..RadioC_A.. and ..ERadioD_A..

Philipp Hortmann linux-staging lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesIn review
  2. v12 patches 5 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2staging: rtl8192e: Remove unused Array Rtl8192PciERadioC_Arraydrivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h drivers/staging/rtl8192e/rtl8192e/table.c +1 more+0 -191 reply
2/2staging: rtl8192e: Remove unused Array Rtl8192PciERadioD_Arraydrivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h drivers/staging/rtl8192e/rtl8192e/table.c +1 more+0 -191 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDan Carpenter
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] staging: rtl8192e: Removing unused arrays ..RadioC_A.. and ..ERadioD_A..

The array Rtl8192PciERadioC_Array and ..RadioD.. is only used in function rtl92e_config_rf_path which is only called in function rtl92e_config_rf. In function rtl92e_config_rf a termination condition for the loop is set to priv->num_total_rf_path = RTL819X_TOTAL_RF_PATH = 2. The loop is only executed with numbers 0 and 1 for eRFPath. So the function rtl92e_config_rf_path is only called with eRFPath for 0 and 1 and never with 2 or 3 that would make the "case RF90_PATH_C:" and
"case RF90_PATH_D:" be called. Remove resulting dead code.
---
V1->V2: Changed argumentation in the description and subject

Tested with rtl8192e
Transferred this patch over wlan connection of rtl8192e

This patch series requires the patches:
"[PATCH 0/2] staging: rtl8192e: Removing rf_type RF_2T4R from driver" "[PATCH] staging: rtl8192e: Change filename r8192E_hwimg.x to table.x" "[PATCH] staging: rtl8192e: Remove call_usermodehelper starting RadioPower.sh" "[PATCH] staging: rtl8192e: Remove function ..dm_check_ac_dc_power calling a script"

Philipp Hortmann (2):
staging: rtl8192e: Remove unused Array Rtl8192PciERadioC_Array
staging: rtl8192e: Remove unused Array Rtl8192PciERadioD_Array

 .../staging/rtl8192e/rtl8192e/r8192E_phy.c    | 24 -------------------
 .../staging/rtl8192e/rtl8192e/r8192E_phy.h    |  4 ----
 drivers/staging/rtl8192e/rtl8192e/table.c     |  6 -----
 drivers/staging/rtl8192e/rtl8192e/table.h     |  4 ----
 4 files changed, 38 deletions(-)
Signature · 1 line
2.39.2