RFC ufs: core: mcq: Add ufshcd_abort() support in MCQ mode
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 RFC Latest5 patches 2 repliesIn review
- v2 RFC3 patches 5 repliesSuperseded
- v1 RFC4 patches 14 repliesSuperseded
Changes in v3 from the cover letter
patch #1:
- In ufshcd_mcq_sq_cleanup(), identify dev_command and correctly use the hwq dedicated for dev command.
- Addressed Bart's comments:
a. ufshcd_mcq_sqe_search(), renaming "i" into "slot"
b. modify ufshcd_mcq_update_sq_head_slot() to return the head slot value. Removed the sq_head_slot member variable.
- Addressed Seo's coment. Stop the SQ before the ufshcd_mcq_sqe_search() and restart the SQ after the search is done.
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | ufs: mcq: Add supporting functions for mcq abortdrivers/ drivers/ drivers/ +1 more | +218 | 2 replies | |
| 2/5 | ufs: mcq: Add support for clean up mcq resourcesdrivers/ | +37 | 0 replies | |
| 3/5 | ufs: mcq: Added ufshcd_mcq_abort()drivers/ drivers/ drivers/ | +74 | 0 replies | |
| 4/5 | ufs: mcq: Use ufshcd_mcq_poll_cqe_lock() in mcq modedrivers/ drivers/ drivers/ +2 more | +6 | 0 replies | |
| 5/5 | ufs: core: Add error handling for MCQ modedrivers/ | +70 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [RFC PATCH v3 0/5] ufs: core: mcq: Add ufshcd_abort() support in MCQ mode
This patch series enable support for ufshcd_abort() and error handler in MCQ mode. The first 3 patches are for supporting ufshcd_abort().
The 4th and 5th patches are for supporting error handler.
Bao D. Nguyen (5):
ufs: mcq: Add supporting functions for mcq abort
ufs: mcq: Add support for clean up mcq resources
ufs: mcq: Added ufshcd_mcq_abort()
ufs: mcq: Use ufshcd_mcq_poll_cqe_lock() in mcq mode
ufs: core: Add error handling for MCQ mode
---v2->v3:
patch #1:
- In ufshcd_mcq_sq_cleanup(), identify dev_command and correctly use the hwq dedicated for dev command.
- Addressed Bart's comments:
a. ufshcd_mcq_sqe_search(), renaming "i" into "slot"
b. modify ufshcd_mcq_update_sq_head_slot() to return the head slot value. Removed the sq_head_slot member variable.
- Addressed Seo's coment. Stop the SQ before the ufshcd_mcq_sqe_search() and restart the SQ after the search is done.
patch #4 and #5: new patches for error handling.
Error handling support will go together with ufshcd_abort() support.
---v1->v2:
patch #1
- Removed ufshcd_mcq_cqe_search()
- Removed mcq_poll_ms from the hba. Replaced with MCQ_POLL_MS
patch #2
- Changed the type of mask argument from u32 to unsigned long in function ufshcd_clear_cmds()
patch #3
- Removed the ufshcd_mcq_cqe_search error case
---
drivers/ufs/core/ufs-mcq.c | 257 ++++++++++++++++++++++++++++++++++++++++- drivers/ufs/core/ufshcd-priv.h | 15 ++- drivers/ufs/core/ufshcd.c | 139 ++++++++++++++++++---- drivers/ufs/host/ufs-qcom.c | 2 +- include/ufs/ufshcd.h | 2 +- include/ufs/ufshci.h | 17 +++ 6 files changed, 404 insertions(+), 28 deletions(-)
Signature · 1 line
2.7.4