Skip to content

staging: rtl8192e: Remove unused RF90_PATH_C and ..D starting .._phyreg.h

Philipp Hortmann linux-staging lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12staging: rtl8192e: Remove unused RF90_PATH_C and ..D in rtl92e_config_rfdrivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c+0 -40 replies
2/12staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfintfsdrivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h+0 -30 replies
3/12staging: rtl8192e: Remove unused variable rfintfidrivers/staging/rtl8192e/rtl8192e/r8190P_def.h drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h+0 -80 replies
4/12staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfintfo and ..fedrivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h+0 -60 replies
5/12staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rf3wireOffsetdrivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h+0 -40 replies
6/12staging: rtl8192e: Remove unused variable rfLSSI_Select and rfTxGainStagedrivers/staging/rtl8192e/rtl8192e/r8190P_def.h drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h+0 -140 replies
7/12staging: rtl8192e: Remove unused variable rfHSSIPara1 and rfSwitchControldrivers/staging/rtl8192e/rtl8192e/r8190P_def.h drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h+0 -180 replies
8/12staging: rtl8192e: Remove unused variable rfAGCControl1 and rfAGCControl2drivers/staging/rtl8192e/rtl8192e/r8190P_def.h drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h+0 -160 replies
9/12staging: rtl8192e: Remove unused variable rfRxIQImbalance and rfRxAFEdrivers/staging/rtl8192e/rtl8192e/r8190P_def.h drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h+0 -210 replies
10/12staging: rtl8192e: Remove unused variable rfTxIQImbalance and rfTxAFEdrivers/staging/rtl8192e/rtl8192e/r8190P_def.h drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h+0 -170 replies
11/12staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfLSSIReadBackdrivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h+0 -50 replies
12/12staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfHSSIPara2drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phyreg.h+0 -40 replies

Reviews trailers per patch

None of the 12 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDan Carpenter
SeriesR-b
1/12
2/12
3/12
4/12
5/12
6/12
7/12
8/12
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/12] staging: rtl8192e: Remove unused RF90_PATH_C and ..D starting .._phyreg.h

Remove unused RF90_PATH_C and RF90_PATH_D. Justification can be quite complex. Some variables are unused then those are completely removed.

The following code lines are mandatory:

enum rf90_radio_path {
	RF90_PATH_A = 0,
	RF90_PATH_B = 1,
	RF90_PATH_C = 2,
	RF90_PATH_D = 3,
	RF90_PATH_MAX
};

Index is saved in variable name: eRFPath

Code likes to shorten variable name to the array with this line:
pPhyReg = &priv->phy_reg_def[eRFPath];

Tested with rtl8192e
Transferred this patch over wlan connection of rtl8192e

Philipp Hortmann (12):
staging: rtl8192e: Remove unused RF90_PATH_C and ..D in
rtl92e_config_rf
staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfintfs
staging: rtl8192e: Remove unused variable rfintfi
staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfintfo and

    ..fe

staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rf3wireOffset
staging: rtl8192e: Remove unused variable rfLSSI_Select and
rfTxGainStage
staging: rtl8192e: Remove unused variable rfHSSIPara1 and
rfSwitchControl
staging: rtl8192e: Remove unused variable rfAGCControl1 and
rfAGCControl2
staging: rtl8192e: Remove unused variable rfRxIQImbalance and rfRxAFE
staging: rtl8192e: Remove unused variable rfTxIQImbalance and rfTxAFE
staging: rtl8192e: Remove unused RF90_PATH_C and ..D for
rfLSSIReadBack
staging: rtl8192e: Remove unused RF90_PATH_C and ..D for rfHSSIPara2

 .../staging/rtl8192e/rtl8192e/r8190P_def.h    | 11 ---
 .../rtl8192e/rtl8192e/r8190P_rtl8256.c        |  4 --
 .../staging/rtl8192e/rtl8192e/r8192E_phy.c    | 68 -------------------
 .../staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 37 ----------
 4 files changed, 120 deletions(-)
Signature · 1 line
2.39.2