Skip to content

staging: rtl8192e: Join constants in r8192E_phy.h

Philipp Hortmann linux-staging lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12staging: rtl8192e: Join constants AGCTAB_ArrayLength with ..LengthPciEdrivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h drivers/staging/rtl8192e/rtl8192e/table.c +1 more+4 -50 replies
2/12staging: rtl8192e: Join constants MACPHY_ArrayLength with ..LengthPciEdrivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h drivers/staging/rtl8192e/rtl8192e/table.h+3 -40 replies
3/12staging: rtl8192e: Join constants RadioA_ArrayLength with ..LengthPciEdrivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h drivers/staging/rtl8192e/rtl8192e/table.c +1 more+4 -50 replies
4/12staging: rtl8192e: Join constants RadioB_ArrayLength with ..LengthPciEdrivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h drivers/staging/rtl8192e/rtl8192e/table.c +1 more+4 -50 replies
5/12staging: rtl8192e: Join constants MACPHY_Array_PGLength with ..LengthPciEdrivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h drivers/staging/rtl8192e/rtl8192e/table.h+3 -40 replies
6/12staging: rtl8192e: Join constants PHY_REG_1T2RArray.. with ..LengthPciEdrivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h drivers/staging/rtl8192e/rtl8192e/table.c +1 more+4 -60 replies
7/12staging: rtl8192e: Join constants Rtl819XMACPHY_..PG with Rtl8192PciE..drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h drivers/staging/rtl8192e/rtl8192e/table.c +1 more+3 -40 replies
8/12staging: rtl8192e: Join constants Rtl819XMACPHY_.. with Rtl8192PciE..drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h drivers/staging/rtl8192e/rtl8192e/table.c +1 more+3 -40 replies
9/12staging: rtl8192e: Join constants Rtl819XRadioA_.. with ..RadioA_..drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h drivers/staging/rtl8192e/rtl8192e/table.c +1 more+5 -60 replies
10/12staging: rtl8192e: Join constants Rtl819XRadioB_.. with ..RadioB_..drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h drivers/staging/rtl8192e/rtl8192e/table.c +1 more+5 -60 replies
11/12staging: rtl8192e: Join constants Rtl819XAGCTAB_.. with ..PciEAGCTAB..drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h drivers/staging/rtl8192e/rtl8192e/table.c +1 more+3 -40 replies
12/12staging: rtl8192e: Join constants Rtl819XPHY_REG_.. with ..PciEPHY_REG_..drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h drivers/staging/rtl8192e/rtl8192e/table.c +1 more+3 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/12] staging: rtl8192e: Join constants in r8192E_phy.h

There are a number of constants that change the name with a similar line like:
#define AGCTAB_ArrayLength AGCTAB_ArrayLengthPciE
This makes code reading very unconfortable as there are always two searches required where one should do the job. Renaming the two variables to one to increase readability.

Tested with rtl8192e
Transferred this patch over wlan connection of rtl8192e

Philipp Hortmann (12):
staging: rtl8192e: Join constants AGCTAB_ArrayLength with ..LengthPciE
staging: rtl8192e: Join constants MACPHY_ArrayLength with ..LengthPciE
staging: rtl8192e: Join constants RadioA_ArrayLength with ..LengthPciE
staging: rtl8192e: Join constants RadioB_ArrayLength with ..LengthPciE
staging: rtl8192e: Join constants MACPHY_Array_PGLength with
..LengthPciE
staging: rtl8192e: Join constants PHY_REG_1T2RArray.. with
..LengthPciE
staging: rtl8192e: Join constants Rtl819XMACPHY_..PG with

    Rtl8192PciE..
  staging: rtl8192e: Join constants Rtl819XMACPHY_.. with Rtl8192PciE..
  staging: rtl8192e: Join constants Rtl819XRadioA_.. with ..RadioA_..
  staging: rtl8192e: Join constants Rtl819XRadioB_.. with ..RadioB_..
  staging: rtl8192e: Join constants Rtl819XAGCTAB_.. with ..PciEAGCTAB..
  staging: rtl8192e: Join constants Rtl819XPHY_REG_.. with
    ..PciEPHY_REG_..
 .../staging/rtl8192e/rtl8192e/r8192E_phy.c    | 32 +++++++++----------
 .../staging/rtl8192e/rtl8192e/r8192E_phy.h    | 14 --------
 drivers/staging/rtl8192e/rtl8192e/table.c     | 12 +++----
 drivers/staging/rtl8192e/rtl8192e/table.h     | 24 +++++++-------
 4 files changed, 34 insertions(+), 48 deletions(-)
Signature · 1 line
2.39.2