Skip to content

Fixing ACPI error reporting display

Elliott Mitchell xen-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 9 repliesIn review
  2. v22 patches 7 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3x86/APIC: include full string with error_interrupt() error messagesxen/arch/x86/apic.c+9 -92 replies
2/3x86/APIC: modify error_interrupt() to output using single printk()xen/arch/x86/apic.c+7 -53 replies
3/3x86/APIC: adjustments to error_interrupt() loopxen/arch/x86/apic.c+2 -21 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchJan Beulich
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] Fixing ACPI error reporting display

This series has been seen previously. The issue is pretty simple, if ACPI errors occur there is a high probability they will occur on multiple cores at once. Since there is no locking for printk() there is a need to emit the entire error with a single printk().

I believe this is roughly where things left off. The loop adjustment had been requested to be broken into a separate step. I had also goofed when adjusting the handling and the string order had gotten reversed.

I'm unsure how best to make the printk() more maintainable. Yet more "%s" and entries[#] will be needed if additional bits get defined. I'm inclined to keep the string broken apart to hint as to how it matches the entry list. I'm okay with everything being fully concatenated if that is felt best.

Elliott Mitchell (3):
x86/APIC: include full string with error_interrupt() error messages x86/APIC: modify error_interrupt() to output using single printk() x86/APIC: adjustments to error_interrupt() loop

 xen/arch/x86/apic.c | 32 +++++++++++++++++---------------
 1 file changed, 17 insertions(+), 15 deletions(-)
Signature · 1 line
2.30.2