Skip to content

btrfs-progs: convert: follow default v2 cache setting

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs-progs: make check/clear-cache.c to be separate from check/main.ccheck/clear-cache.c check/clear-cache.h check/main.c+52 -463 replies
2/2btrfs-progs: convert: follow the default free space tree settingMakefile convert/main.c+24 -10 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchNeal Gompa
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] btrfs-progs: convert: follow default v2 cache setting

Although btrfs-convert has followed the new default setting in v5.15 release, it doesn't work.

The problem is the convert workflow itself (making an temporary btrfs first, then sync the inodes) doesn't really create the free space tree nor the needed super block flags.

And during the inodes sync phase, we generate v1 cache, causing the result btrfs to be v1 cache populated, and cause test case failure for subpage testing.

This patchset would fix the converted btrfs at the final stage, by clearing the existing v1 cache first, then create and populate a valid free space tree, with needed super block flags.

There seems to be a behavior change in mkfs.ext4 (e2fsprogs 1.47), that would create an orphan inode (with fixed ino number 12), and btrfs-convert would follow the ext4 to create an orphan in btrfs too, causing btrfs check to complain.

So for now, I can not do convert testing due to the newly updated e2fsprogs...

Qu Wenruo (2):
btrfs-progs: make check/clear-cache.c to be separate from check/main.c
btrfs-progs: convert: follow the default free space tree setting

 Makefile            |  2 +-
 check/clear-cache.c | 84 ++++++++++++++++++++++++---------------------
 check/clear-cache.h |  8 +++--
 check/main.c        |  6 ++--
 convert/main.c      | 23 +++++++++++++
 5 files changed, 76 insertions(+), 47 deletions(-)
Signature · 1 line
2.39.2