Skip to content

mlxsw: Add support for new reset flow

Petr Machata linux-pci netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 18 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6mlxsw: reg: Move 'mpsc' definition in 'mlxsw_reg_infos'drivers/net/ethernet/mellanox/mlxsw/reg.h+1 -11 reply
2/6mlxsw: reg: Add Management Capabilities Mask Registerdrivers/net/ethernet/mellanox/mlxsw/reg.h+74 -04 replies
3/6mlxsw: Extend MRSR pack() function to support new commandsdrivers/net/ethernet/mellanox/mlxsw/pci.c drivers/net/ethernet/mellanox/mlxsw/reg.h+13 -31 reply
4/6mlxsw: pci: Rename mlxsw_pci_sw_reset()drivers/net/ethernet/mellanox/mlxsw/pci.c+5 -51 reply
5/6mlxsw: pci: Move software reset code to a separate functiondrivers/net/ethernet/mellanox/mlxsw/pci.c+11 -51 reply
6/6mlxsw: pci: Add support for new reset flowdrivers/net/ethernet/mellanox/mlxsw/pci.c drivers/net/ethernet/mellanox/mlxsw/pci_hw.h+155 -110 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchIdo SchimmelPetr MachataSimon Horman
1/6R-b R-b R-b
2/6R-b R-b
3/6R-b R-b R-b
4/6R-b R-b
5/6R-b R-b R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH net-next 0/6] mlxsw: Add support for new reset flow

Amit Cohen writes:

The driver resets the device during probe and during a devlink reload. The current reset method reloads the current firmware version or a pending one, if one was previously flashed using devlink. However, the reset does not take down the PCI link, preventing the PCI firmware from being upgraded, unless the system is rebooted.

To solve this problem, a new reset command was implemented in the firmware. Unlike the current command, after issuing the new command the device will not start the reset immediately, but only after the PCI link was disabled.

For Spectrum-4, the firmware will support the new reset flow, which includes PCI reset. Add support for the new flow and use it only after verifying it is supported by the current firmware version by querying the Management Capabilities Mask (MCAM) register.

Patch set overview:
Patch #1 fixes a wrong order of registers' definitions. Patches #2-#3 add the required registers and fields for new reset support.
Patches #4-#5 prepare reset code to be extended.
Patch #6 adds support for the new reset flow.

Amit Cohen (6):
mlxsw: reg: Move 'mpsc' definition in 'mlxsw_reg_infos'
mlxsw: reg: Add Management Capabilities Mask Register
mlxsw: Extend MRSR pack() function to support new commands
mlxsw: pci: Rename mlxsw_pci_sw_reset()
mlxsw: pci: Move software reset code to a separate function
mlxsw: pci: Add support for new reset flow

 drivers/net/ethernet/mellanox/mlxsw/pci.c    | 169 ++++++++++++++++++-
 drivers/net/ethernet/mellanox/mlxsw/pci_hw.h |   5 +
 drivers/net/ethernet/mellanox/mlxsw/reg.h    |  90 +++++++++-
 3 files changed, 254 insertions(+), 10 deletions(-)
Signature · 1 line
2.39.0