Skip to content

staging: rtl8192u: clean up comments in r8192U_dm.c

Khadija Kamran linux-staging lkml outreachy 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 5 repliesIn review
  2. v23 patches 1 replySuperseded
  3. v13 patches 5 repliesSuperseded

Changes in v3 from the cover letter

- Split patch 3 in two patches, one for '*' on subsequent lines and one for '*/' on separate line, as suggested by Dan.
- Add spaces after '*' in patch 3

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4staging: rtl8192u: remove change history from commentsdrivers/staging/rtl8192u/r8192U_dm.c+0 -452 replies
2/4staging: rtl8192u: remove commented out codedrivers/staging/rtl8192u/r8192U_dm.c+0 -1230 replies
3/4staging: rtl8192u: add '*' on subsequent lines in block commentdrivers/staging/rtl8192u/r8192U_dm.c+9 -80 replies
4/4staging: rtl8192u: add '*/' on separate line in block commentsdrivers/staging/rtl8192u/r8192U_dm.c+14 -73 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/4] staging: rtl8192u: clean up comments in r8192U_dm.c

Clean up several comments in file r8192U_dm.c

Changes in v3:
- Split patch 3 in two patches, one for '*' on subsequent lines and one for '*/' on separate line, as suggested by Dan.
- Add spaces after '*' in patch 3

Changes in v2:
- Remove the 'commented code' and 'revision history' before reformatting the block comments, as suggested by Greg. There is no use in fixing comments, only to remove them in the next commits
- Patch 1: Changed the description and removed extra blank lines under the change history
- Patch 2: Changed the subject and description

This patchset was created after reviewer feedback on an initial patch. The feedback suggested additional cleanup comments. Link to the first patch:
https://lore.kernel.org/outreachy/ZB2a5zwYpBZ%2F6qwU@khadija-virtual-machine/

Khadija Kamran (4):
staging: rtl8192u: remove change history from comments
staging: rtl8192u: remove commented out code
staging: rtl8192u: add '*' on subsequent lines in block comment
staging: rtl8192u: add '*/' on separate line in block comments

 drivers/staging/rtl8192u/r8192U_dm.c | 206 +++------------------------
 1 file changed, 23 insertions(+), 183 deletions(-)
Signature · 1 line
2.34.1