Skip to content

objtool: warning improvements

Josh Poimboeuf lkml 3 versions – Applied

Status from this message: The following commit has been merged into the objtool/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 1 replyApplied
  2. v29 patches 14 repliesApplied
  3. v15 patches 10 repliesSuperseded

Changes in v3 from the cover letter

- dropped merged patches and rebased on tip/objtool/core
- moved list of noreturn functions to separate file
- improved WARN_INSN() to do single evaluation of insn arg

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/8objtool: Limit unreachable warnings to once per functiontools/objtool/check.c tools/objtool/include/objtool/elf.h tools/objtool/include/objtool/warn.h+10 -30 replies
2/8objtool: Add verbose option for disassembling affected functionstools/objtool/Documentation/objtool.txt tools/objtool/builtin-check.c tools/objtool/check.c +1 more+88 -00 replies
3/8objtool: Include backtrace in verbose modetools/objtool/Documentation/objtool.txt tools/objtool/check.c tools/objtool/include/objtool/warn.h+20 -240 replies
4/8objtool: Detect missing __noreturn annotationstools/objtool/Documentation/objtool.txt tools/objtool/check.c+19 -10 replies
5/8objtool: Ignore exc_double_fault() __noreturn warningstools/objtool/check.c+30 -10 replies
6/8objtool: Remove superfluous global_noreturns entriestools/objtool/check.c+0 -20 replies
7/8tools/lib/subcmd: Replace NORETURN usage with __noreturntools/lib/subcmd/parse-options.h tools/lib/subcmd/subcmd-util.h+4 -90 replies
8/8objtool: Move noreturn function list to separate filetools/objtool/Documentation/objtool.txt tools/objtool/check.c tools/objtool/noreturns.h+50 -440 replies

Reviews trailers per patch

None of the 8 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMiroslav Benes
SeriesR-b
1/8
2/8
3/8
4/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/8] objtool: warning improvements

v3:
- dropped merged patches and rebased on tip/objtool/core
- moved list of noreturn functions to separate file
- improved WARN_INSN() to do single evaluation of insn arg

Josh Poimboeuf (8):
objtool: Limit unreachable warnings to once per function
objtool: Add verbose option for disassembling affected functions
objtool: Include backtrace in verbose mode
objtool: Detect missing __noreturn annotations
objtool: Ignore exc_double_fault() __noreturn warnings
objtool: Remove superfluous global_noreturns entries tools/lib/subcmd: Replace NORETURN usage with __noreturn
objtool: Move noreturn function list to separate file

 tools/lib/subcmd/parse-options.h        |   8 +-
 tools/lib/subcmd/subcmd-util.h          |   5 +-
 tools/objtool/Documentation/objtool.txt |  10 ++
 tools/objtool/builtin-check.c           |   5 +
 tools/objtool/check.c                   | 195 ++++++++++++++++--------
 tools/objtool/include/objtool/builtin.h |   1 +
 tools/objtool/include/objtool/elf.h     |   1 +
 tools/objtool/include/objtool/warn.h    |  21 ++-
 tools/objtool/noreturns.h               |  45 ++++++
 9 files changed, 214 insertions(+), 77 deletions(-)
 create mode 100644 tools/objtool/noreturns.h
Signature · 1 line
2.39.2