net: dsa: add support for MT7988
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest15 patches 23 repliesIn review
Changes since RFC v3 from the cover letter
* WARN_ON_ONCE if register read fails
* move probing of the reset GPIO and reset controller link out of common probe function, as they are not actually common
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/15 | net: dsa: mt7530: make some noise if register read failsdrivers/ | +2 | 1 reply | |
| 2/15 | net: dsa: mt7530: refactor SGMII PCS creationdrivers/ | +50 | 1 reply | |
| 3/15 | net: dsa: mt7530: use unlocked regmap accessorsdrivers/ | +14 | 1 reply | |
| 4/15 | net: dsa: mt7530: use regmap to access switch register spacedrivers/ drivers/ | +60 | 2 replies | |
| 5/15 | net: dsa: mt7530: move SGMII PCS creation to mt7530_probe functiondrivers/ | +7 | 1 reply | |
| 6/15 | net: dsa: mt7530: introduce mutex helpersdrivers/ | +36 | 0 replies | |
| 7/15 | net: dsa: mt7530: move p5_intf_modes() function to mt7530.cdrivers/ drivers/ | +18 | 0 replies | |
| 8/15 | net: dsa: mt7530: introduce mt7530_probe_common helper functiondrivers/ | +54 | 0 replies | |
| 9/15 | net: dsa: mt7530: introduce mt7530_remove_common helper functiondrivers/ | +12 | 0 replies | |
| 10/15 | net: dsa: mt7530: split-off common parts from mt7531_setupdrivers/ | +55 | 0 replies | |
| 11/15 | net: dsa: mt7530: introduce separate MDIO driverMAINTAINERS drivers/ drivers/ +3 more | +300 | 0 replies | |
| 12/15 | net: dsa: mt7530: skip locking if MDIO bus isn't presentdrivers/ | +4 | 0 replies | |
| 13/15 | net: dsa: mt7530: add support for 10G link modes for CPU portdrivers/ | +6 | 2 replies | |
| 14/15 | net: dsa: mt7530: introduce driver for MT7988 built-in switchMAINTAINERS drivers/ drivers/ +3 more | +206 | 12 replies | |
| 15/15 | dt-bindings: net: dsa: mediatek,mt7530: add mediatek,mt7988-switchDocumentation/ | +24 | 2 replies |
Reviews trailers per patch
14 of 15 patches have a Reviewed-by or Acked-by.
| Patch | Andrew Lunn |
|---|---|
| 1/15 | R-b |
| 2/15 | R-b |
| 3/15 | R-b |
| 4/15 | R-b |
| 5/15 | R-b |
| 6/15 | R-b |
| 7/15 | R-b |
| 8/15 | R-b |
| 9/15 | R-b |
| 10/15 | R-b |
| 11/15 | R-b |
| 12/15 | R-b |
| 13/15 | R-b |
| 14/15 | R-b |
| 15/15 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next 00/15] net: dsa: add support for MT7988
The MediaTek MT7988 SoC comes with a built-in switch very similar to previous MT7530 and MT7531. However, the switch address space is mapped into the SoCs memory space rather than being connected via MDIO. Using MMIO simplifies register access and also removes the need for a bus lock, and for that reason also makes interrupt handling more light-weight.
Note that this is different from previous SoCs like MT7621 and MT7623N which also came with an integrated MT7530-like switch which yet had to be accessed via MDIO.
Split-off the part of the driver registering an MDIO driver, then add another module acting as MMIO/platform driver.
The whole series has been tested on various MediaTek boards:
* MT7623A + MT7530 (BPi-R2)
* MT7986A + MT7531 (BPi-R3)
* MT7988A reference board
Changes since RFC v3:
* WARN_ON_ONCE if register read fails
* move probing of the reset GPIO and reset controller link out of common probe function, as they are not actually common
Changes since RFC v2:
* split into many small commits to ease review
* introduce helper functions to reduce code duplication
* use helpers for locking to make lock-skipping easier and less ugly to implement.
* add dt-bindings for mediatek,mt7988-switch
Changes since initial RFC:
* use regmap for register access and move register access to bus- specific driver
* move initialization of MT7531 SGMII PCS to MDIO driver
Daniel Golle (15):
net: dsa: mt7530: make some noise if register read fails
net: dsa: mt7530: refactor SGMII PCS creation
net: dsa: mt7530: use unlocked regmap accessors
net: dsa: mt7530: use regmap to access switch register space
net: dsa: mt7530: move SGMII PCS creation to mt7530_probe function
net: dsa: mt7530: introduce mutex helpers
net: dsa: mt7530: move p5_intf_modes() function to mt7530.c
net: dsa: mt7530: introduce mt7530_probe_common helper function
net: dsa: mt7530: introduce mt7530_remove_common helper function
net: dsa: mt7530: split-off common parts from mt7531_setup
net: dsa: mt7530: introduce separate MDIO driver
net: dsa: mt7530: skip locking if MDIO bus isn't present
net: dsa: mt7530: add support for 10G link modes for CPU port
net: dsa: mt7530: introduce driver for MT7988 built-in switch
dt-bindings: net: dsa: mediatek,mt7530: add mediatek,mt7988-switch
.../bindings/net/dsa/mediatek,mt7530.yaml | 26 +- MAINTAINERS | 3 + drivers/net/dsa/Kconfig | 28 +- drivers/net/dsa/Makefile | 4 +- drivers/net/dsa/mt7530-mdio.c | 271 ++++++++++ drivers/net/dsa/mt7530-mmio.c | 101 ++++ drivers/net/dsa/mt7530.c | 511 ++++++++---------- drivers/net/dsa/mt7530.h | 38 +- 8 files changed, 668 insertions(+), 314 deletions(-) create mode 100644 drivers/net/dsa/mt7530-mdio.c create mode 100644 drivers/net/dsa/mt7530-mmio.c
base-commit: 4ddd6375c3ef6756d492ea5466408cace097121b
Signature · 1 line
2.39.2