Skip to content

migration/ram.c: Refactor compress code

Lukas Straub qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest13 patches 16 repliesIn review
  2. v114 patches 8 repliesSuperseded

Changes in v2 from the cover letter

- Add postcopy tests with compress enabled
- Use page_size variable in "ram-compress.c: Make target independent"
- Squash "ram.c: Remove unused include after moving out code" with "ram.c: Move core compression code into its own file"
- Add Reviewed-by: Tags

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13qtest/migration-test.c: Add postcopy tests with compress enabledtests/qtest/migration-test.c+53 -303 replies
2/13ram.c: Let the compress threads return a CompressResult enummigration/ram.c+22 -121 reply
3/13ram.c: Dont change param->block in the compress threadmigration/ram.c+4 -21 reply
4/13ram.c: Reset result after sending queued datamigration/ram.c+22 -101 reply
5/13ram.c: Do not call save_page_header() from compress threadsmigration/ram.c+35 -91 reply
6/13ram.c: Call update_compress_thread_counts from compress_send_queued_datamigration/ram.c+6 -121 reply
7/13ram.c: Remove last ram.c dependency from the core compress codemigration/ram.c+17 -101 reply
8/13ram.c: Introduce whitespace (squash with next patch)migration/ram.c+12 -01 reply
9/13ram.c: Move core compression code into its own filemigration/meson.build migration/ram-compress.c migration/ram-compress.h +1 more+343 -2560 replies
10/13ram.c: Remove whitespace (squash with previous patch)migration/ram.c+0 -181 reply
11/13ram.c: Move core decompression code into its own filemigration/ram-compress.c migration/ram-compress.h migration/ram.c+208 -2041 reply
12/13ram compress: Assert that the file buffer matches the resultmigration/qemu-file.c migration/qemu-file.h migration/ram-compress.c +1 more+19 -01 reply
13/13ram-compress.c: Make target independentmigration/meson.build migration/ram-compress.c+11 -81 reply

Reviews trailers per patch

10 of 13 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPhilippe Mathieu-DaudéJuan Quintela
SeriesR-b
1/13R-b
2/13R-b
3/13R-b
4/13R-b
5/13R-b
6/13R-b
7/13R-b
8/13
9/13
10/13
11/13R-b R-b
12/13R-b
13/13R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/13] migration/ram.c: Refactor compress code

This series refactors the ram compress code.

It first removes ram.c dependencies from the core compress code, then moves it out to its own file. Finally, on the migration destination side the initialisation and cleanup of compress threads is moved out of ram.c to migration.c. This allows using COLO with compress enabled.

Changes since v1:
- Add postcopy tests with compress enabled
- Use page_size variable in "ram-compress.c: Make target independent"
- Squash "ram.c: Remove unused include after moving out code" with "ram.c: Move core compression code into its own file"
- Add Reviewed-by: Tags

Lukas Straub (13):
qtest/migration-test.c: Add postcopy tests with compress enabled ram.c: Let the compress threads return a CompressResult enum ram.c: Dont change param->block in the compress thread ram.c: Reset result after sending queued data
ram.c: Do not call save_page_header() from compress threads ram.c: Call update_compress_thread_counts from
compress_send_queued_data
ram.c: Remove last ram.c dependency from the core compress code ram.c: Introduce whitespace (squash with next patch) ram.c: Move core compression code into its own file ram.c: Remove whitespace (squash with previous patch) ram.c: Move core decompression code into its own file ram compress: Assert that the file buffer matches the result ram-compress.c: Make target independent

 migration/meson.build        |   5 +-
 migration/qemu-file.c        |  11 +
 migration/qemu-file.h        |   1 +
 migration/ram-compress.c     | 484 ++++++++++++++++++++++++++++++++++
 migration/ram-compress.h     |  70 +++++
 migration/ram.c              | 485 +++--------------------------------
 tests/qtest/migration-test.c |  83 +++---
 7 files changed, 660 insertions(+), 479 deletions(-)
 create mode 100644 migration/ram-compress.c
 create mode 100644 migration/ram-compress.h

--
2.40.0