Skip to content

btrfs: adjust async discard tuning

Boris Burkov linux-btrfs 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 3 repliesIn review
  2. v12 patches 2 repliesSuperseded

Changelog from the cover letter

v2: actually set the limit to 1k, not 10k.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs: set default discard iops_limit to 1000fs/btrfs/discard.c+1 -11 reply
2/2btrfs: reinterpret async discard iops_limit=0 as no delayfs/btrfs/discard.c+9 -71 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchNeal Gompa
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] btrfs: adjust async discard tuning

Since discard=async became the implicit default in btrfs in the 6.2 kernel, there have been numerous complaints about discard being too spread out on workstation systems. This results in situations like a users drive not being idle for an unexpectedly long period of time.

This is caused by a relatively low default iops limit of 10, so this series raises the default limit to 1000 (1ms delay) and modifies a weird fallback behavior for limit=0 to be interpreted as unlimited.

---
Changelog:
v2: actually set the limit to 1k, not 10k.

Boris Burkov (2):
btrfs: set default discard iops_limit to 1000
btrfs: reinterpret async discard iops_limit=0 as no delay

 fs/btrfs/discard.c | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)
Signature · 1 line
2.40.0