Skip to content

RFC YAML template for MPTCP netlink API

Davide Caratti mptcp 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest5 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5tools: ynl: add uns-admin-perm to genetlink legacyDocumentation/netlink/genetlink-legacy.yaml+1 -10 replies
2/5tools: ynl: fix bug in case of multiple nested attributes of the same typetools/net/ynl/ynl-gen-c.py+2 -13 replies
3/5Documentation: netlink: add a YAML spec for mptcpDocumentation/netlink/specs/mptcp.yaml+361 -02 replies
4/5mptcp: uapi: add header files generated from YAML specinclude/uapi/linux/mptcp.h include/uapi/linux/mptcp_pm.h+149 -1630 replies
5/5net/mptcp: use netlink policy generated from YAML specnet/mptcp/Makefile net/mptcp/pm_netlink.c net/mptcp/pm_nl.c +3 more+152 -1031 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH RFC mptcp-net-next 0/5] YAML template for MPTCP netlink API

Related: #377

Notes:
- the attributes in the operation list is not really good, we probably need to specify better what parameters are used in the .doit() function (though the generated code is the same). Specifying 'remote_addr' either in 'request' or in 'reply' would probably make patch 2/5 useless.
- I didn't add the multicast groups on purpose. ynl-c.py is not able to generate the operation list for genetlink-legacy, so all this part (including multicast groups) needs to be left unspecified in the template.

Davide Caratti (5):
tools: ynl: add uns-admin-perm to genetlink legacy
tools: ynl: fix bug in case of multiple nested attributes of the same
type
Documentation: netlink: add a YAML spec for mptcp
mptcp: uapi: add header files generated from YAML spec net/mptcp: use netlink policy generated from YAML spec

 Documentation/netlink/genetlink-legacy.yaml |   2 +-
 Documentation/netlink/specs/mptcp.yaml      | 361 ++++++++++++++++++++
 include/uapi/linux/mptcp.h                  | 167 +--------
 include/uapi/linux/mptcp_pm.h               | 145 ++++++++
 net/mptcp/Makefile                          |   3 +-
 net/mptcp/pm_netlink.c                      | 107 +-----
 net/mptcp/pm_nl.c                           |  91 +++++
 net/mptcp/pm_nl.h                           |  39 +++
 net/mptcp/pm_userspace.c                    |   9 +-
 net/mptcp/protocol.h                        |   6 +-
 tools/net/ynl/ynl-gen-c.py                  |   3 +-
 11 files changed, 665 insertions(+), 268 deletions(-)
 create mode 100644 Documentation/netlink/specs/mptcp.yaml
 create mode 100644 include/uapi/linux/mptcp_pm.h
 create mode 100644 net/mptcp/pm_nl.c
 create mode 100644 net/mptcp/pm_nl.h
Signature · 1 line
2.39.2