Skip to content

fscrypt: preliminary rearrangmeents of key setup

Sweet Tea Dorminy linux-btrfs linux-fscrypt llvm oe-kbuild oe-kbuild-all 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest8 patches 13 repliesIn review
  2. v58 patches 1 replySuperseded
  3. v48 patches 0 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v311 patches0 repliesSuperseded
v211 patches12 repliesSuperseded
v110 patches2 repliesSuperseded

Changes in v6 from the cover letter

- Reword 'make infos have a pointer to prepared keys' to elaborate on why it is a useful change.

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8fscrypt: move inline crypt decision to info setupfs/crypto/keysetup.c+4 -41 reply
2/8fscrypt: split and rename setup_file_encryption_key()fs/crypto/keysetup.c+52 -252 replies
3/8fscrypt: split setup_per_mode_enc_key()fs/crypto/keysetup.c+37 -242 replies
4/8fscrypt: move dirhash key setup away from IO key setupfs/crypto/keysetup.c+21 -161 reply
5/8fscrypt: reduce special-casing of IV_INO_LBLK_32fs/crypto/keysetup.c+32 -301 reply
6/8fscrypt: move all the shared mode key setup deeperfs/crypto/keysetup.c+88 -432 replies
7/8fscrypt: make infos have a pointer to prepared keysfs/crypto/crypto.c fs/crypto/fname.c fs/crypto/fscrypt_private.h +3 more+18 -121 reply
8/8fscrypt: make prepared keys record their typefs/crypto/fscrypt_private.h fs/crypto/keysetup.c fs/crypto/keysetup_v1.c+41 -183 replies

Reviews trailers per patch

7 of 8 patches have a Reviewed-by or Acked-by.

PatchJosef Bacik
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/8] fscrypt: preliminary rearrangmeents of key setup

For btrfs extent encryption, prepared keys need to be asynchronously freed after the fscrypt_info is freed. This set of various rearrangements of key setup turns the prepared key member of the info into a pointer so this is possible.

Patchset is built on kdave/misc-next as per base commit and needs a tiny fixup to apply to fscrypt/for-next. It passes ext4/f2fs tests for me.

[1] https://lore.kernel.org/linux-fscrypt/[email protected]/

Changelog:
v6:
- Reword 'make infos have a pointer to prepared keys' to elaborate on why it is a useful change.

Sweet Tea Dorminy (8):
fscrypt: move inline crypt decision to info setup
fscrypt: split and rename setup_file_encryption_key()
fscrypt: split setup_per_mode_enc_key()
fscrypt: move dirhash key setup away from IO key setup
fscrypt: reduce special-casing of IV_INO_LBLK_32
fscrypt: move all the shared mode key setup deeper
fscrypt: make infos have a pointer to prepared keys
fscrypt: make prepared keys record their type

 fs/crypto/crypto.c          |   2 +-
 fs/crypto/fname.c           |   4 +-
 fs/crypto/fscrypt_private.h |  33 +++-
 fs/crypto/inline_crypt.c    |   4 +-
 fs/crypto/keysetup.c        | 357 +++++++++++++++++++++++-------------
 fs/crypto/keysetup_v1.c     |   9 +-
 6 files changed, 265 insertions(+), 144 deletions(-)

base-commit: 54d2161835d828a9663f548f61d1d9c3d3482122

Signature · 1 line
2.41.0