Skip to content

RFC ext4: misc left over folio changes

Ritesh Harjani (IBM) linux-ext4 linux-fsdevel 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest5 patches 18 repliesApplied
  2. v1 RFC4 patches 8 repliesSuperseded

Changes in v2 from the cover letter

=========
1. Added Patch-2 which removes PAGE_SIZE assumption from mpage_submit_folio. (IMO, this was a missed left over from previous conversion).
2. Addressed a small review comment from Matthew in the tracepoint patch to take (inode, folio).
3. Added Reviewed-by from Matthew.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/5ext4: kill unused function ext4_journalled_write_inline_datafs/ext4/ext4.h fs/ext4/inline.c+0 -280 replies
2/5ext4: Remove PAGE_SIZE assumption of folio from mpage_submit_foliofs/ext4/inode.c+1 -113 replies
3/5ext4: Change remaining tracepoints to use foliofs/ext4/inode.c include/trace/events/ext4.h+17 -160 replies
4/5ext4: Make mpage_journal_page_buffers use foliofs/ext4/inode.c+13 -151 reply
5/5ext4: Make ext4_write_inline_data_end() use foliofs/ext4/ext4.h fs/ext4/inline.c fs/ext4/inode.c+17 -150 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMatthew Wilcox (Oracle)Ritesh Harjani (IBM)Eric Biggers
SeriesR-b R-b
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [RFCv2 0/5] ext4: misc left over folio changes

Hello,

Please find v2 of the left over folio conversion changes. It would be nice if you could also review Patch-2 and Patch-4.

v1 -> v2
=========
1. Added Patch-2 which removes PAGE_SIZE assumption from mpage_submit_folio. (IMO, this was a missed left over from previous conversion).
2. Addressed a small review comment from Matthew in the tracepoint patch to take (inode, folio).
3. Added Reviewed-by from Matthew.

Testing
========
I haven't found any new failures in my fstests testing with "-g auto" with default config.

Ritesh Harjani (IBM) (5):
ext4: kill unused function ext4_journalled_write_inline_data
ext4: Remove PAGE_SIZE assumption of folio from mpage_submit_folio
ext4: Change remaining tracepoints to use folio
ext4: Make mpage_journal_page_buffers use folio
ext4: Make ext4_write_inline_data_end() use folio

 fs/ext4/ext4.h              | 10 ++-----
 fs/ext4/inline.c            | 27 +----------------
 fs/ext4/inode.c             | 60 ++++++++++++++++++++-----------------
 include/trace/events/ext4.h | 26 ++++++++--------
 4 files changed, 48 insertions(+), 75 deletions(-)

--
2.40.1