Skip to content

inet6: Backport complete patchset for inet6_destroy_sock() call modification

Ziyang Xuan netdev stable 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5udp: Call inet6_destroy_sock() in setsockopt(IPV6_ADDRFORM).include/net/ipv6.h net/ipv6/af_inet6.c net/ipv6/ipv6_sockglue.c+15 -120 replies
2/5tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().include/net/ipv6.h include/net/udp.h include/net/udplite.h +6 more+46 -150 replies
3/5inet6: Remove inet6_destroy_sock() in sk->sk_prot->destroy().net/ipv6/ping.c net/ipv6/raw.c net/ipv6/tcp_ipv6.c +2 more+1 -190 replies
4/5dccp: Call inet6_destroy_sock() via sk->sk_destruct().net/dccp/dccp.h net/dccp/ipv6.c net/dccp/proto.c +1 more+17 -80 replies
5/5sctp: Call inet6_destroy_sock() via sk->sk_destruct().net/sctp/socket.c+21 -80 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchMatthieu Baerts
1/5
2/5
3/5R-b
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 5.4 0/5] inet6: Backport complete patchset for inet6_destroy_sock() call modification

5.4 LTS has backported commit ca43ccf41224 ("dccp/tcp: Avoid negative sk_forward_alloc by ipv6_pinfo.pktoptions.") and commit 62ec33b44e0f ("net:
Remove WARN_ON_ONCE(sk->sk_forward_alloc) from sk_stream_kill_queues()."), but these are incomplete. There are some patches that have not been backported including key pre-patches commit d38afeec26ed ("tcp/udp:
Call inet6_destroy_sock() in IPv6 sk->sk_destruct().") and commit b5fc29233d28 ("inet6: Remove inet6_destroy_sock() in sk->sk_prot->destroy()."). Without them, there are some memory leak bugs.

Backport complete patchset for inet6_destroy_sock() call modification.

Kuniyuki Iwashima (5):
udp: Call inet6_destroy_sock() in setsockopt(IPV6_ADDRFORM). tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().
inet6: Remove inet6_destroy_sock() in sk->sk_prot->destroy().
dccp: Call inet6_destroy_sock() via sk->sk_destruct().
sctp: Call inet6_destroy_sock() via sk->sk_destruct().

 include/net/ipv6.h       |  2 ++
 include/net/udp.h        |  2 +-
 include/net/udplite.h    |  8 --------
 net/dccp/dccp.h          |  1 +
 net/dccp/ipv6.c          | 15 ++++++++-------
 net/dccp/proto.c         |  8 +++++++-
 net/ipv4/udp.c           |  9 ++++++---
 net/ipv4/udplite.c       |  8 ++++++++
 net/ipv6/af_inet6.c      | 15 ++++++++++++++-
 net/ipv6/ipv6_sockglue.c | 20 ++++++++------------
 net/ipv6/ping.c          |  6 ------
 net/ipv6/raw.c           |  2 --
 net/ipv6/tcp_ipv6.c      |  8 +-------
 net/ipv6/udp.c           | 17 ++++++++++++++---
 net/ipv6/udp_impl.h      |  1 +
 net/ipv6/udplite.c       |  9 ++++++++-
 net/l2tp/l2tp_ip6.c      |  2 --
 net/sctp/socket.c        | 29 +++++++++++++++++++++--------
 18 files changed, 100 insertions(+), 62 deletions(-)
Signature · 1 line
2.25.1