Skip to content

RFC Improvements for RealTek 2.5G Ethernet PHYs

Daniel Golle lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest8 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8net: phy: realtek: rtl8221: allow to configure SERDES modedrivers/net/phy/realtek.c+53 -00 replies
2/8net: phy: realtek: switch interface mode for RTL822x seriesdrivers/net/phy/realtek.c+24 -20 replies
3/8net: phy: realtek: use genphy_soft_reset for 2.5G PHYsdrivers/net/phy/realtek.c+6 -00 replies
4/8net: phy: realtek: disable SGMII in-band AN for 2.5G PHYsdrivers/net/phy/realtek.c+8 -00 replies
5/8net: phy: realtek: use phy_read_paged instead of open codingdrivers/net/phy/realtek.c+1 -33 replies
6/8net: phy: realtek: use inline functions for 10GbE advertisementdrivers/net/phy/realtek.c+5 -170 replies
7/8net: phy: realtek: check validity of 10GbE link-partner advertisementdrivers/net/phy/realtek.c+4 -00 replies
8/8net: phy: realtek: setup ALDPS on RTL822xdrivers/net/phy/realtek.c+29 -00 replies

Reviews trailers per patch

None of the 8 patches has a Reviewed-by or Acked-by.

PatchYevhen Kolomeiko
1/8
2/8
3/8
4/8T-b
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH net-next 0/8] Improvements for RealTek 2.5G Ethernet PHYs

Improve support for RealTek 2.5G Ethernet PHYs (RTL822x series). The PHYs can operate with Clause-22 and Clause-45 MDIO.

When using Clause-45 it is desireable to avoid rate-adapter mode and rather have the MAC interface mode follow the PHY speed. The PHYs support 2500Base-X for 2500M, and Cisco SGMII for 1000M/100M/10M.

Also prepare support for proprietary RealTek HiSGMII mode which will be needed for situations when used with RealTek switch or router SoCs such as RTL93xx.

Add support for Link Down Power Saving Mode (ALDPS) which is already supported for older RTL821x series 1GbE PHYs.

Make sure that link-partner advertised modes are only used if the advertisement can be considered valid. Otherwise we are seeing false-positives warning about downscaling eventhough higher speeds are not actually advertised by the link partner.

While at it, improve the driver by using existing macros and inline functions which are not actually vendor specific.

Alexander Couzens (1):
net: phy: realtek: rtl8221: allow to configure SERDES mode

Chukun Pan (1):
net: phy: realtek: switch interface mode for RTL822x series

Daniel Golle (6):
net: phy: realtek: use genphy_soft_reset for 2.5G PHYs
net: phy: realtek: disable SGMII in-band AN for 2.5G PHYs
net: phy: realtek: use phy_read_paged instead of open coding
net: phy: realtek: use inline functions for 10GbE advertisement
net: phy: realtek: check validity of 10GbE link-partner advertisement
net: phy: realtek: setup ALDPS on RTL822x

 drivers/net/phy/realtek.c | 152 ++++++++++++++++++++++++++++++++------
 1 file changed, 130 insertions(+), 22 deletions(-)

base-commit: fbc1449d385d65be49a8d164dfd3772f2cb049ae

Signature · 1 line
2.40.0