Skip to content

Remove unused rf_set_sens variable

Yogesh Hegde linux-staging lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest4 patches 1 replyIn review
  2. v44 patches 1 replySuperseded

Changes in v5 from the cover letter

1. Rebased onto latest staging-testing branch per feedback from [email protected]

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4staging: rtl8192e: Remove unused rf_set_sens variabledrivers/staging/rtl8192e/rtl8192e/rtl_core.h drivers/staging/rtl8192e/rtl8192e/rtl_wx.c+2 -180 replies
2/4staging: rtl8192e: Remove unused _rtl92e_wx_get_sens functiondrivers/staging/rtl8192e/rtl8192e/rtl_wx.c+0 -100 replies
3/4staging: rtl8192e: Remove unused _rtl92e_wx_set_sens functiondrivers/staging/rtl8192e/rtl8192e/rtl_wx.c+0 -200 replies
4/4staging: rtl8192e: Remove unused sens and max_sens from r8192_priv structdrivers/staging/rtl8192e/rtl8192e/rtl_core.h+0 -20 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by.

PatchPhilipp Hortmann
SeriesT-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/4] Remove unused rf_set_sens variable

The rf_set_sens variable is declared but never set, so it is always NULL. Cleanup the unused rf_set_sens variable. Remove functions _rtl92e_wx_get_sens and _rtl92e_wx_set_sens which always returned error code after removal of rf_set_sens variable.
Cleanup unused max_sens and sens variable.
The patches are required to be applied in sequence.

Changes in v5:
1. Rebased onto latest staging-testing branch per feedback from [email protected]

Changes in v4:
1. Split changes into patch series per feedback from [email protected]

Changes in v3:
1. Fixed description to fit within 75 chars
2. Added suggested tags
per feedback from [email protected]

Changes in v2:
1. Removed function definition rf_set_sens
2. Removed usage of variable priv->rf_set_sens
3. Removed functions _rtl92e_wx_get_sens and _rtl92e_wx_set_sens
4. Cleaned up the variables sens and max_sens used in these functions

Changes in v1:
1. Fix comparison to NULL of variable rf_set_sens

Yogesh Hegde (4):
staging: rtl8192e: Remove unused rf_set_sens variable
staging: rtl8192e: Remove unused _rtl92e_wx_get_sens function
staging: rtl8192e: Remove unused _rtl92e_wx_set_sens function
staging: rtl8192e: Remove unused sens and max_sens from r8192_priv
struct

 drivers/staging/rtl8192e/rtl8192e/rtl_core.h |  3 --
 drivers/staging/rtl8192e/rtl8192e/rtl_wx.c   | 45 --------------------
 2 files changed, 48 deletions(-)
Signature · 1 line
2.34.1