Skip to content

btrfs: small improvement to leaf dump

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs: print-tree: accept const extent buffer pointerfs/btrfs/ctree.c fs/btrfs/ctree.h fs/btrfs/extent-tree.c +2 more+14 -140 replies
2/2btrfs: improve leaf dump and error handlingfs/btrfs/ctree.c fs/btrfs/extent-tree.c+59 -680 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] btrfs: small improvement to leaf dump

The first patch is just constify the tree dump infrastructure, exposed during the development.

The second patch is the main dish, inspired by a report that turns out to be bitflip in extent tree.
However the leaf dump in dmesg is pretty large (100+ slots), needs to manually search the leaf using the bytenr from the error messages.

Thus if we can output the slot number, it would be much easier to locate the problem, just like what we did in tree-checker.

Qu Wenruo (2):
btrfs: print-tree: accept const extent buffer pointer
btrfs: improve leaf dump and error handling

 fs/btrfs/ctree.c       |   8 +--
 fs/btrfs/ctree.h       |   2 +-
 fs/btrfs/extent-tree.c | 125 +++++++++++++++++++----------------------
 fs/btrfs/print-tree.c  |  16 +++---
 fs/btrfs/print-tree.h  |   4 +-
 5 files changed, 73 insertions(+), 82 deletions(-)
Signature · 1 line
2.39.2