Skip to content

btrfs-progs: fix -Wmissing-prototypes warnings and enable that warning option

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest7 patches 8 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7btrfs-progs: remove function btrfs_check_allocatable_zones()kernel-shared/zoned.c+0 -581 reply
2/7btrfs-progs: libbtrfs: remove the support for fs without uuid treelibbtrfs/send-utils.c libbtrfs/send-utils.h+0 -4163 replies
3/7btrfs-progs: crypto/blake2: remove blake2 simple APIcrypto/blake2b-ref.c+0 -43 replies
4/7btrfs-progs: crypto/blake2: move optimized declarations to blake2b.hcrypto/blake2.h crypto/blake2b-ref.c+5 -40 replies
5/7btrfs-progs: crypto/sha: declare the x86 optimized implementationcrypto/sha.h crypto/sha256-x86.c+5 -00 replies
6/7btrfs-progs: fix -Wmissing-prototypes warningscmds/qgroup.c cmds/reflink.c cmds/subvolume-list.c +9 more+13 -70 replies
7/7btrfs-progs: Makefile: enable -Wmissing-prototypesMakefile+2 -10 replies

Reviews trailers per patch

1 of 7 patches has a Reviewed-by or Acked-by.

PatchAnand Jain
1/7R-b
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/7] btrfs-progs: fix -Wmissing-prototypes warnings and enable that warning option

We have at least one case that some function is exported but never got utilized in the first place.

Let's prevent this problem from happening again by enable -Wmissing-prototypes to debug builds at least.

Fixes for the existing warnings are split into several patches:

- Remove unused functions
Two patches, the first is to remove a function that never got utilized from the introduction.

The second is to remove a very old feature (only for <3.12 kernels) in libbtrfs.
In fact this functionality for fs without an UUID tree is already broken during previous cleanups.
(Need to export subvol_uuid_search_add() and
subvol_uuid_search_finit(), as it's callers' responsibility to search for the target subvolume by themselves)

And since no one is complaining ever since, there is really no need to maintain such an old and deprecated feature in libbtrfs.

- Fixes for crypto related function
Two patches, one for each csum algo (blake2 and sha256). Involves extra declarations in the headers.

- Trivial fixes
Mostly unexport and add needed headers.

Qu Wenruo (7):
btrfs-progs: remove function btrfs_check_allocatable_zones()
btrfs-progs: libbtrfs: remove the support for fs without uuid tree
btrfs-progs: crypto/blake2: remove blake2 simple API
btrfs-progs: crypto/blake2: move optimized declarations to blake2b.h
btrfs-progs: crypto/sha: declare the x86 optimized implementation
btrfs-progs: fix -Wmissing-prototypes warnings
btrfs-progs: Makefile: enable -Wmissing-prototypes

 Makefile              |   3 +-
 cmds/qgroup.c         |   2 +-
 cmds/reflink.c        |   2 +-
 cmds/subvolume-list.c |   2 +-
 common/device-utils.c |   2 +-
 common/utils.c        |   2 +-
 crypto/blake2.h       |   5 +
 crypto/blake2b-ref.c  |   8 -
 crypto/sha.h          |   3 +
 crypto/sha256-x86.c   |   2 +
 kernel-shared/ulist.c |   2 +-
 kernel-shared/zoned.c |  60 +------
 libbtrfs/send-utils.c | 396 ------------------------------------------
 libbtrfs/send-utils.h |  20 ---
 tune/change-csum.c    |   1 +
 tune/change-uuid.c    |   1 +
 tune/convert-bgt.c    |   1 +
 tune/seeding.c        |   1 +
 tune/tune.h           |   2 +
 19 files changed, 25 insertions(+), 490 deletions(-)
Signature · 1 line
2.39.2