Skip to content

selftests: fcnal: Test SO_DONTROUTE socket option.

Guillaume Nault netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 5 repliesApplied 4/4
  2. v14 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Use two different nettest options for setting SO_DONTROUTE either on the server or on the client socket.

- Use the above feature to run a single 'nettest -B' instance per test (instead of having two nettest processes for server and client).

Patches in v2 All 4 applied

#Subject and filesSizeRepliesApplied
1/4selftests: Add SO_DONTROUTE option to nettest.tools/testing/selftests/net/nettest.c+45 -11 replyApplied
2/4selftests: fcnal: Test SO_DONTROUTE on TCP sockets.tools/testing/selftests/net/fcnal-test.sh+56 -01 replyApplied
3/4selftests: fcnal: Test SO_DONTROUTE on UDP sockets.tools/testing/selftests/net/fcnal-test.sh+17 -02 repliesApplied
4/4selftests: fcnal: Test SO_DONTROUTE on raw and ping sockets.tools/testing/selftests/net/fcnal-test.sh+14 -01 replyApplied

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchDavid Ahern
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 net-next 0/4] selftests: fcnal: Test SO_DONTROUTE socket option.

The objective is to cover kernel paths that use the RTO_ONLINK flag in .flowi4_tos. This way we'll be able to safely remove this flag in the future by properly setting .flowi4_scope instead. With these selftests in place, we can make sure this won't introduce regressions.

For more context, the final objective is to convert .flowi4_tos to dscp_t, to ensure that ECN bits don't influence route and fib-rule lookups (see commit a410a0cf9885 ("ipv6: Define dscp_t and stop taking ECN bits into account in fib6-rules")).

These selftests only cover IPv4, as SO_DONTROUTE has no effect on IPv6 sockets.

v2:
- Use two different nettest options for setting SO_DONTROUTE either on the server or on the client socket.

- Use the above feature to run a single 'nettest -B' instance per test (instead of having two nettest processes for server and client).

Guillaume Nault (4):
selftests: Add SO_DONTROUTE option to nettest.
selftests: fcnal: Test SO_DONTROUTE on TCP sockets.
selftests: fcnal: Test SO_DONTROUTE on UDP sockets.
selftests: fcnal: Test SO_DONTROUTE on raw and ping sockets.

 tools/testing/selftests/net/fcnal-test.sh | 87 +++++++++++++++++++++++
 tools/testing/selftests/net/nettest.c     | 46 +++++++++++-
 2 files changed, 132 insertions(+), 1 deletion(-)
Signature · 1 line
2.30.2