Skip to content

Improvements for RealTek 2.5G Ethernet PHYs

Daniel Golle linux-mediatek lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 of 8 patches 8 repliesIn review

Changes since RFC from the cover letter

* Turns out paged read used to identify the PHY needs to be hardcoded for the simple reason that the function pointers for paged operations have not yet been populated at this point. Hence keep open-coding it, but use helper function and make sure it happening while the MDIO bus mutex is locked.

6 of 8 patches are in this archive. The cover letter announces 8.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
3/8net: phy: realtek: use genphy_soft_reset for 2.5G PHYsdrivers/net/phy/realtek.c+6 -00 replies
4/8net: phy: realtek: disable SGMII in-band AN for 2.5G PHYsdrivers/net/phy/realtek.c+14 -10 replies
5/8net: phy: realtek: make sure paged read is protected by mutexdrivers/net/phy/realtek.c+5 -30 replies
6/8net: phy: realtek: use inline functions for 10GbE advertisementdrivers/net/phy/realtek.c+5 -170 replies
7/8net: phy: realtek: check validity of 10GbE link-partner advertisementdrivers/net/phy/realtek.c+4 -00 replies
8/8net: phy: realtek: setup ALDPS on RTL8221Bdrivers/net/phy/realtek.c+29 -00 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchYevhen KolomeikoSteen Hegelund
SeriesR-b
3/8
4/8T-b
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/8] Improvements for RealTek 2.5G Ethernet PHYs

Improve support for RealTek 2.5G Ethernet PHYs (RTL822x series). The PHYs can operate with Clause-22 and Clause-45 MDIO.

When using Clause-45 it is desireable to avoid rate-adapter mode and rather have the MAC interface mode follow the PHY speed. The PHYs support 2500Base-X for 2500M, and Cisco SGMII for 1000M/100M/10M.

Also prepare support for proprietary RealTek HiSGMII mode which will be needed for situations when used with RealTek switch or router SoCs such as RTL839x or RTL93xx.

Add support for Link Down Power Saving Mode (ALDPS) which is already supported for older RTL821x series 1GbE PHYs.

Make sure that link-partner advertised modes are only used if the advertisement can be considered valid. Otherwise we are seeing false-positives warning about downscaling eventhough higher speeds are not actually advertised by the link partner.

While at it, use helper function for paged operation and make sure to use use locking for that as well.

Changes since RFC:
* Turns out paged read used to identify the PHY needs to be hardcoded for the simple reason that the function pointers for paged operations have not yet been populated at this point. Hence keep open-coding it, but use helper function and make sure it happening while the MDIO bus mutex is locked.

Alexander Couzens (1):
net: phy: realtek: rtl8221: allow to configure SERDES mode

Chukun Pan (1):
net: phy: realtek: switch interface mode for RTL822x series

Daniel Golle (6):
net: phy: realtek: use genphy_soft_reset for 2.5G PHYs
net: phy: realtek: disable SGMII in-band AN for 2.5G PHYs
net: phy: realtek: make sure paged read is protected by mutex
net: phy: realtek: use inline functions for 10GbE advertisement
net: phy: realtek: check validity of 10GbE link-partner advertisement
net: phy: realtek: setup ALDPS on RTL8221B

 drivers/net/phy/realtek.c | 161 ++++++++++++++++++++++++++++++++------
 1 file changed, 138 insertions(+), 23 deletions(-)
Signature · 1 line
2.40.0