Skip to content

mptcp: a bunch of data race fixes

Paolo Abeni mptcp 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 9 repliesIn review
  2. v14 patches 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5mptcp: add annotations around msk->subflow accessesnet/mptcp/protocol.c net/mptcp/protocol.h+15 -90 replies
2/5mptcp: consolidate passive msk socket initializationnet/mptcp/protocol.c net/mptcp/protocol.h net/mptcp/subflow.c+33 -380 replies
3/5mptcp: fix data race around msk->first accessnet/mptcp/protocol.c+3 -30 replies
4/5mptcp: add annotations around sk->sk_shutdown accessesnet/mptcp/protocol.c+16 -130 replies
5/5mptcp: fix active subflow finalization.net/mptcp/protocol.c+14 -97 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMat Martineau
SeriesR-b
1/5
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 mptcp-net 0/5] mptcp: a bunch of data race fixes

The patch 1 && 4 are direct response to recently reported KCSAN splat.

The patch 2 && 3 are just by code inspection of related code path. Patch 3/5 is there mostly to make the next one simple, even if the race mentioned in such patch should be real (but very tiny, if possible at all).

This iteration addresses a compile warning in patch 2/5 reported by kbuild bot.

Patch 5/5 is new in this round, fixes an unrelated issue found by code inspection. I should have posted separatelly

Paolo Abeni (5):
mptcp: add annotations around msk->subflow accesses
mptcp: consolidate passive msk socket initialization
mptcp: fix data race around msk->first access
mptcp: add annotations around sk->sk_shutdown accesses
mptcp: fix active subflow finalization.

 net/mptcp/protocol.c | 111 +++++++++++++++++++++++++++----------------
 net/mptcp/protocol.h |  14 ++++--
 net/mptcp/subflow.c  |  28 +----------
 3 files changed, 81 insertions(+), 72 deletions(-)
Signature · 1 line
2.40.1