Skip to content

fetch: smallish cleanups

Patrick Steinhardt git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9fetch: drop unused DISPLAY_FORMAT_UNKNOWN enum valuebuiltin/fetch.c+0 -11 reply
2/9fetch: drop unneeded NULL-check for `remote_ref`builtin/fetch.c+2 -31 reply
3/9fetch: pass through `fetch_config` directlybuiltin/fetch.c+16 -153 replies
4/9fetch: use `fetch_config` to store "fetch.prune" valuebuiltin/fetch.c+5 -41 reply
5/9fetch: use `fetch_config` to store "fetch.pruneTags" valuebuiltin/fetch.c+5 -40 replies
6/9fetch: use `fetch_config` to store "fetch.showForcedUpdates" valuebuiltin/fetch.c+21 -140 replies
7/9fetch: use `fetch_config` to store "fetch.recurseSubmodules" valuebuiltin/fetch.c+16 -150 replies
8/9fetch: use `fetch_config` to store "fetch.parallel" valuebuiltin/fetch.c+8 -70 replies
9/9fetch: use `fetch_config` to store "submodule.fetchJobs" valuebuiltin/fetch.c+6 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] fetch: smallish cleanups

Hi,

the dust around machine-parsable fetches has settled a bit, so as promised this patch series contains a smallish set of cleanups for git-fetch(1).

- Patch 1/9 drops the unused DISPLAY_FORMAT_UNKNOWN enum.

- Patch 2/9 drops a useless NULL check as pointed out by Peff.

- The remaining patches convert git_fetch_config() to not use global state anymore, but instead to parse all config values into the newly introduced fetch_config structure.

The patches depend on 15ba44f1b4 (Merge branch 'ps/fetch-output-format', 2023-05-15). As this is the last merge before v2.41.0-rc0 I've decided to thus base this series on top of that tag.

Patrick

Patrick Steinhardt (9):
fetch: drop unused DISPLAY_FORMAT_UNKNOWN enum value
fetch: drop unneeded NULL-check for remote_ref
fetch: pass through fetch_config directly
fetch: use fetch_config to store "fetch.prune" value
fetch: use fetch_config to store "fetch.pruneTags" value
fetch: use fetch_config to store "fetch.showForcedUpdates" value
fetch: use fetch_config to store "fetch.recurseSubmodules" value
fetch: use fetch_config to store "fetch.parallel" value
fetch: use fetch_config to store "submodule.fetchJobs" value

 builtin/fetch.c | 147 ++++++++++++++++++++++++++----------------------
 1 file changed, 79 insertions(+), 68 deletions(-)
Signature · 1 line
2.40.1